This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Remove old service, 3rd try #1776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i.e. Revert "Revert "Remove Old Service, 2nd try (#1732)" (#1758)" This reverts commit c80f7b6. Closes #1757. We now have some evidence that the polkadot validator was producing blocks after all; the reason the blocks_constructed metric was 0 was that as a new metric it hadn't yet been incorporated into that branch's codebase. See #1757 (comment) As this PR is based on a newer `master` branch than the previous one, that should hopefully no longer be an issue.
coriolinus
added
A3-in_progress
github-actions
bot
added
A0-please_review
bkchr
approved these changes
Oct 5, 2020
Member
bkchr
left a comment
bkchr
left a comment
There was a problem hiding this comment.
I did not checked everything for a third time, I skimmed the changes, while assuming that you did not changed anything ;)
|
Needs merge with master. |
…vice-3 Note that it was necessary to make polkadot_runtime_parachains::paras::Origin public, for macro-related reasons which don't seem to make a lot of sense to me. I can only assume that this ultimately derives from a Substrate update.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i.e.
Revert "Revert "Remove Old Service, 2nd try (#1732)" (#1758)"
This reverts commit c80f7b6.
Closes #1757. The substance of the code changes has already been reviewed
in #1732 and #1630.
We now have some evidence that the polkadot validator was producing
blocks after all; the reason the blocks_constructed metric was 0 was
that as a new metric it hadn't yet been incorporated into that
branch's codebase. See
#1757 (comment)
As this PR is based on a newer
masterbranch than the previous one,that should hopefully no longer be an issue.