Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
ab14b90
HRMP: Update the impl guide
pepyakin Oct 28, 2020
c318044
HRMP: Incorporate the channel notifications into the guide
pepyakin Sep 30, 2020
130accb
HRMP: Renaming in the impl guide
pepyakin Oct 28, 2020
e1e4eb0
HRMP: Constrain the maximum number of HRMP messages per candidate
pepyakin Oct 28, 2020
8ef66ec
XCM: Introduce HRMP related message types
pepyakin Sep 30, 2020
196c4a4
HRMP: Data structures and plumbing
pepyakin Sep 14, 2020
71bb7a6
HRMP: Configuration
pepyakin Sep 19, 2020
3dacd77
HRMP: Data layout
pepyakin Oct 6, 2020
6e7979b
HRMP: Acceptance & Enactment
pepyakin Sep 23, 2020
8363874
HRMP: Test base logic
pepyakin Nov 4, 2020
e6a84dc
Update adder collator
pepyakin Nov 2, 2020
19f01ac
HRMP: Runtime API for accessing inbound messages
pepyakin Nov 3, 2020
d61440b
HRMP: Add diagnostic logging in acceptance criteria
pepyakin Nov 3, 2020
71aa0bb
HRMP: Additional tests
pepyakin Nov 4, 2020
f4b03ce
Self-review fixes
pepyakin Nov 5, 2020
0fe6c9a
save test refactorings for the next time
pepyakin Nov 5, 2020
0dce9f8
Missed a return statement.
pepyakin Nov 5, 2020
3555327
a formatting blip
pepyakin Nov 5, 2020
af77075
Add missing logic for appending HRMP digests
pepyakin Nov 5, 2020
1b2368b
Remove the channel contents vectors which became empty
pepyakin Nov 5, 2020
02945d9
Tighten HRMP channel digests invariants.
pepyakin Nov 5, 2020
8448078
Apply suggestions from code review
pepyakin Nov 6, 2020
ee5078f
Remove a note about sorting for channel id
pepyakin Nov 6, 2020
37c1fdd
Add missing rustdocs to the configuration
pepyakin Nov 6, 2020
be1013c
Clarify and update the invariant for HrmpChannelDigests
pepyakin Nov 6, 2020
e546c3c
Make the onboarding invariant less sloppy
pepyakin Nov 6, 2020
9e6e3c2
Make `CandidateCheckContext` use T::BlockNumber for hrmp_watermark
pepyakin Nov 6, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review
Co-authored-by: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com>
  • Loading branch information
pepyakin and coriolinus authored Nov 6, 2020
commit 8448078f732ab1ef7afbffb71064f67ba3c02c73
2 changes: 1 addition & 1 deletion roadmap/implementers-guide/src/runtime/inclusion.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ All failed checks should lead to an unrecoverable error making the block invalid
1. call `Router::check_upward_messages(para, commitments.upward_messages)` to check that the upward messages are valid.
1. call `Router::check_processed_downward_messages(para, commitments.processed_downward_messages)` to check that the DMQ is properly drained.
1. call `Router::check_hrmp_watermark(para, commitments.hrmp_watermark)` for each candidate to check rules of processing the HRMP watermark.
1. using `Router::check_outbound_hrmp(sender, commitments.horizontal_messages)` ensure that the each candidate send a valid set of horizontal messages
1. using `Router::check_outbound_hrmp(sender, commitments.horizontal_messages)` ensure that the each candidate sent a valid set of horizontal messages
1. create an entry in the `PendingAvailability` map for each backed candidate with a blank `availability_votes` bitfield.
1. create a corresponding entry in the `PendingAvailabilityCommitments` with the commitments.
1. Return a `Vec<CoreIndex>` of all scheduled cores of the list of passed assignments that a candidate was successfully backed for, sorted ascending by CoreIndex.
Expand Down
4 changes: 1 addition & 3 deletions roadmap/implementers-guide/src/runtime/router.md
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,6 @@ struct HrmpChannel {
sender_deposit: Balance,
/// The amount that the recipient supplied as a deposit when accepting opening this channel.
recipient_deposit: Balance,
/// The maximum message size that could be put into the channel.
limit_message_size: u32,
/// The maximum number of messages that can be pending in the channel at once.
max_capacity: u32,
/// The maximum total size of the messages that can be pending in the channel at once.
Expand Down Expand Up @@ -173,7 +171,7 @@ HrmpChannelContents: map HrmpChannelId => Vec<InboundHrmpMessage>;
/// Maintains a mapping that can be used to answer the question:
/// What paras sent a message at the given block number for a given reciever.
/// Invariants:
/// - The para ids vector is never empty.
/// - The inner `Vec<ParaId>` is never empty.
/// - The para ids vector doesn't contain duplicates.
/// - The outer vector is sorted ascending by block number and there are no duplicates.
HrmpChannelDigests: map ParaId => Vec<(BlockNumber, Vec<ParaId>)>;
Expand Down
2 changes: 1 addition & 1 deletion runtime/parachains/src/router/hrmp.rs
Original file line number Diff line number Diff line change
Expand Up @@ -973,7 +973,7 @@ mod tests {
// (a, x) (a, x)
// (a, y) (a, y)
// (b, x) (b, x)
// (b, y) (b, y)
// (b, z) (b, z)
//
// and then that we compare that to the channel list in the `HrmpChannels`.
let channel_set_derived_from_ingress = <Router as Store>::HrmpIngressChannelsIndex::iter()
Expand Down