Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@pepyakin
Copy link
Contributor

@pepyakin pepyakin commented Nov 10, 2020

This PR adds a nifty entrypoint for sending a downward message from root/sudo.

@pepyakin pepyakin added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Nov 10, 2020
@pepyakin pepyakin marked this pull request as draft November 11, 2020 11:17
@pepyakin pepyakin force-pushed the ser-sudo-queue-downward-message branch from e9314d2 to 37a7cb4 Compare November 11, 2020 11:30
Copy link
Member

@shawntabrizi shawntabrizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not have directly used the term sudo here since you really mean root origin which could come from multiple places like democracy, but ya thats just a nitpick

@pepyakin
Copy link
Contributor Author

Yeah, I know. That's just what the module is already called.

@pepyakin pepyakin force-pushed the ser-sudo-queue-downward-message branch from 37a7cb4 to 2739d58 Compare November 16, 2020 14:03
@pepyakin
Copy link
Contributor Author

Rebased against the current master. The sole commit of this PR remains unchanged.

pepyakin and others added 2 commits November 16, 2020 15:24
@pepyakin pepyakin marked this pull request as ready for review November 16, 2020 14:25
@bkchr bkchr merged commit 120d5dd into master Nov 16, 2020
@bkchr bkchr deleted the ser-sudo-queue-downward-message branch November 16, 2020 15:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants