Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@mattrutherford
Copy link
Contributor

Include new parameter in test Configuration

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Nov 19, 2020
@mattrutherford mattrutherford added the A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. label Nov 20, 2020
@mattrutherford mattrutherford requested a review from dvdplm December 1, 2020 16:47
Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane.

@ordian ordian added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Dec 2, 2020
@ghost
Copy link

ghost commented Dec 3, 2020

Waiting for commit status.

@ghost
Copy link

ghost commented Dec 3, 2020

Checks failed; merge aborted.

@mattrutherford mattrutherford removed the A0-please_review Pull request needs code review. label Dec 3, 2020
@ordian ordian merged commit f4aae88 into master Dec 3, 2020
@ordian ordian deleted the companion-7474 branch December 3, 2020 14:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants