Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@shawntabrizi
Copy link
Member

This is a PR to introduce a new proxy type which has the power to specifically reject and remove announced proxy calls.

cc @wpank @ddorgan

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Jan 27, 2021
@shawntabrizi shawntabrizi added B7-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. labels Jan 27, 2021
@ddorgan ddorgan added this to the v0.8.28 milestone Jan 27, 2021
This was referenced Jan 29, 2021
@ddorgan
Copy link
Member

ddorgan commented Feb 3, 2021

FYI to add this type while testing:

{
        "ProxyType": {
                "_enum": [
                        "Any",
                        "NonTransfer",
                        "Governance",
                        "Staking",
                        "IdentityJudgement",
                        "CancelProxy"
                ]
        }
}

Thanks to @jacogr for this info.

@jacogr
Copy link
Contributor

jacogr commented Feb 3, 2021

@ddorgan If you test against Polkadot (which is --dev here), you need to leave a gap after IdentityJudgement, so something like ... "Staking", "Unused", "IdentityJudgement", "CancelProxy"

@shawntabrizi No Westend?

Copy link
Contributor

@wpank wpank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add this to Westend and this should be good to merge I think.

@shawntabrizi
Copy link
Member Author

@ddorgan changes look good

@ddorgan ddorgan self-requested a review February 4, 2021 15:34
Copy link
Member

@ddorgan ddorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@shawntabrizi
Copy link
Member Author

bot merge

@ghost
Copy link

ghost commented Feb 4, 2021

Missing process info; check that the PR belongs to a project column.

Merge can be attempted if:

  • The PR has approval from two core-devs (or one if the PR is labelled insubstantial).
  • The PR has approval from a member of substrateteamleads.
  • The PR is attached to a project column and has approval from the project owner.

See https://github.com/paritytech/parity-processbot#faq

@ddorgan ddorgan added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). and removed A0-please_review Pull request needs code review. labels Feb 4, 2021
@ddorgan
Copy link
Member

ddorgan commented Feb 4, 2021

bot merge

@ghost
Copy link

ghost commented Feb 4, 2021

Trying merge.

@ghost ghost merged commit 05eab3f into master Feb 4, 2021
@ghost ghost deleted the shawntabrizi-cancel-proxy branch February 4, 2021 16:13
s3krit pushed a commit that referenced this pull request Feb 4, 2021
* cancel proxy

* fix

* Remove reject_announcement and add CancelProxy to westend

Co-authored-by: David Dorgan <[email protected]>
@s3krit s3krit mentioned this pull request Feb 4, 2021
2 tasks
s3krit added a commit that referenced this pull request Feb 4, 2021
* Cancel Proxy Type (#2334)

* cancel proxy

* fix

* Remove reject_announcement and add CancelProxy to westend

Co-authored-by: David Dorgan <[email protected]>

* node: pass local authorship info to the transaction pool (#2385)

* node: pass local authorship to the transaction pool

* update substrate

Co-authored-by: Shawn Tabrizi <[email protected]>
Co-authored-by: David Dorgan <[email protected]>
ordian pushed a commit that referenced this pull request Feb 5, 2021
* master:
  node: pass local authorship info to the transaction pool (#2385)
  Explicit Para Lifecycle w/ Upgrades and Downgrades (#2354)
  Cancel Proxy Type (#2334)
  Cargo.lock: Update to libp2p-swarm v0.27.2 (#2384)
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants