Cleanup + get rid of some warnings.

node/network/availability-distribution/src/lib.rs

@@ -42,15 +42,14 @@ mod session_cache;
 const LOG_TARGET: &'static str = "availability_distribution";
 
 /// Availability Distribution metrics.
-/// TODO: Dummy for now.
 type Metrics = ();
 
 /// The availability distribution subsystem.
 pub struct AvailabilityDistributionSubsystem {
 	/// Pointer to a keystore, which is required for determining this nodes validator index.
 	keystore: SyncCryptoStorePtr,
-	/// Prometheus metrics.
-	metrics: Metrics,
+	//// Prometheus metrics.
+	// metrics: Metrics,
 }
 
 impl<Context> Subsystem<Context> for AvailabilityDistributionSubsystem
@@ -72,8 +71,8 @@ where
 
 impl AvailabilityDistributionSubsystem {
 	/// Create a new instance of the availability distribution.
-	pub fn new(keystore: SyncCryptoStorePtr, metrics: Metrics) -> Self {
-		Self { keystore, metrics }
+	pub fn new(keystore: SyncCryptoStorePtr, _metrics: Metrics) -> Self {
+		Self { keystore }
 	}
 
 	/// Start processing work as passed on from the Overseer.

node/network/availability-distribution/src/requester.rs

@@ -57,8 +57,6 @@ pub struct Requester {
 	fetches: HashMap<CandidateHash, FetchTask>,
 
 	/// Localized information about sessions we are currently interested in.
-	///
-	/// This is the current one and the last one.
 	session_cache: SessionCache,
 
 	/// Sender to be cloned for `FetchTask`s.
@@ -73,7 +71,7 @@ impl Requester {
 	///
 	/// You must feed it with `ActiveLeavesUpdate` via `update_fetching_heads` and make it progress
 	/// by advancing the stream.
-	pub(crate) fn new(keystore: SyncCryptoStorePtr) -> Self {
+	pub fn new(keystore: SyncCryptoStorePtr) -> Self {
 		// All we do is forwarding messages, no need to make this big.
 		let (tx, rx) = mpsc::channel(1);
 		Requester {
@@ -86,7 +84,7 @@ impl Requester {
 	/// Update heads that need availability distribution.
 	///
 	/// For all active heads we will be fetching our chunks for availabilty distribution.
-	pub(crate) async fn update_fetching_heads<Context>(
+	pub async fn update_fetching_heads<Context>(
 		&mut self,
 		ctx: &mut Context,
 		update: ActiveLeavesUpdate,

node/network/availability-distribution/src/requester/fetch_task.rs

@@ -58,7 +58,7 @@ pub struct FetchTask {
 	/// stop keeping track of that candidate/chunk.
 	live_in: HashSet<Hash>,
 
-	/// We keep the task around in state `Fetched` until `live_in` becomes empty, to make
+	/// We keep the task around in until `live_in` becomes empty, to make
 	/// sure we won't re-fetch an already fetched candidate.
 	state: FetchedState,
 }
@@ -80,7 +80,7 @@ pub enum FromFetchTask {
 
 	/// Concluded with result.
 	///
-	/// In case of `None` everything was fine, in case of `Some` some validators in the group
+	/// In case of `None` everything was fine, in case of `Some`, some validators in the group
 	/// did not serve us our chunk as expected.
 	Concluded(Option<BadValidators>),
 }

node/network/availability-distribution/src/responder.rs

@@ -14,7 +14,7 @@
 // You should have received a copy of the GNU General Public License
 // along with Polkadot.  If not, see <http://www.gnu.org/licenses/>.
 
-//! Responder answers requests for availability chunks.
+//! Answer requests for availability chunks.
 
 use futures::channel::oneshot;