Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@rphmeier
Copy link
Contributor

@rphmeier rphmeier commented Mar 11, 2021

These metrics should tell us about whether we're seeing no-shows and how long it takes to approve blocks & candidates.

@rphmeier rphmeier added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Mar 11, 2021
@rphmeier
Copy link
Contributor Author

bot merge

@ghost
Copy link

ghost commented Mar 11, 2021

Waiting for commit status.

@ghost ghost merged commit c0f3893 into master Mar 11, 2021
@ghost ghost deleted the rh-approval-noshow-metric branch March 11, 2021 17:58
rphmeier added a commit that referenced this pull request Mar 11, 2021
* some more metrics for approval voting

* fix tests

Co-authored-by: Andronik Ordian <[email protected]>
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants