Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@ordian
Copy link

@ordian ordian commented Mar 12, 2021

See https://github.com/paritytech/ci_cd/issues/64.

The initial version doesn't have automatic notification on failure, but that could be added later. I've spent too much on it already.

@ordian ordian added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Mar 12, 2021
@github-actions github-actions bot added the A3-in_progress Pull request is in progress. No review needed at this stage. label Mar 12, 2021
@ordian ordian marked this pull request as ready for review March 13, 2021 17:18
@ordian ordian added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Mar 13, 2021
@bkchr bkchr requested a review from a team March 13, 2021 19:13
@lovelaced
Copy link
Contributor

lovelaced commented Mar 15, 2021

This looks fine to me, though if you want to go ahead and add a matrix message step it would look something like:

 - steps:
  ...
  - name: bash script step
  ...
  - name: Fuzzer found something
    if: ${{ failure() }}
     uses: s3krit/[email protected]
     with:
         room_id: ${{ secrets.MATRIX_ROOM_ID_FUZZER }}
         access_token: ${{ secrets.MATRIX_ACCESS_TOKEN_FUZZER }}
         message: "uh oh... ${{ github.event.workflow_run.url }}"
         server: "matrix.parity.io"

kianenigma and others added 14 commits March 19, 2021 14:09
* Change something

* cargo run --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/

* cargo run --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/

* cargo run --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/

* cargo run --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/

* cargo run --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/

* cargo run --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/

Co-authored-by: Parity Benchmarking Bot <[email protected]>
Currently we will take all leaves and give that to the overseer on
startup, but this is a bad idea when the finality is lagging for
example. There can be many of unfinalized leaves, we don't even need to
look at anymore. To solve this, the pr adds a maximum of 4 leaves we
forward to the overseer and the pr also checks that we only pass uncles
of the best block.
…ons per block) (#2358)

* service: update for substrate PR #7640

* update substrate

* Add Pallet Babe to Integration Tests Runtime

Co-authored-by: André Silva <[email protected]>
Co-authored-by: Shawn Tabrizi <[email protected]>
* Companion for Substrate#8386

paritytech/substrate#8386

* "Update Substrate"

Co-authored-by: parity-processbot <>
* Introduce collation fetching protocol

also move to mod.rs

* Allow `PeerId`s in requests to network bridge.

* Fix availability distribution tests.

* Move CompressedPoV to primitives.

* Request based collator protocol: validator side

- Missing: tests
- Collator side
- don't connect, if not connected

* Fixes.

* Basic request based collator side.

* Minor fix on collator side.

* Don't connect in requests in collation protocol.

Also some cleanup.

* Fix PoV distribution

* Bump substrate

* Add back metrics + whitespace fixes.

* Add back missing spans.

* More cleanup.

* Guide update.

* Fix tests

* Handle results in tests.

* Fix weird compilation issue.

* Add missing )

* Get rid of dead code.

* Get rid of redundant import.

* Fix runtime build.

* Cleanup.

* Fix wasm build.

* Format fixes.

Thanks @andronik !
…ime macro) (#2629)

* Replace 'Module' with 'Pallet'.

* "Update Substrate"

* fix babe usage

* fix benchmark

Co-authored-by: parity-processbot <>
Co-authored-by: thiolliere <[email protected]>
Breaks compatibility for distributing PoV and PersistentValidationData between validators.

Ref #2442
* Update for the new substrate client API

* Code review suggestions

* Update substrate
* Don't accept incoming connections for collators

on the `Collation` peer set.

* Better docs.
* master:
  Don't accept incoming connections for collators (#2644)
  Improve the logging (#2645)
  Update for the new substrate client API (#2570)
  integrate faster erasure code (#2608)
  Companion for #8372 (Replace 'Module' with 'Pallet' in construct_runtime macro) (#2629)
  Request based collation fetching (#2621)
  Companion for Substrate#8386 (#2634)
  Polkadot companion for Substrate PR #7640 (Store multiple Justifications per block) (#2358)
  yet another set of logging improvements (#2638)
  Reduce number of active leaves at startup (#2631)
  re benchmark  (#2630)
  Fix wrong deposit amount in council voters. (#2562)
  Add /data symlink to Docker containers (#2627)
  Companion for sub/8176 (#2622)
  Remove TODO from substrate#2986 (#2628)
  update ring to 0.16.20 (#2626)
  New slots/auctions architecture (#2294)
  add tracing when no assignment in candidate selection (#2623)
  Backing and collator protocol traces including para-id (#2620)
  more diagnostic logs for approval-voting (#2618)
@ordian
Copy link
Author

ordian commented Mar 19, 2021

Saw something that shouldn't act like this.

Thanks, fixed in 86333c5.

Also, the default timeout is 360 min.

This is 6 hours, we run fuzzers for 5 hours, 1 extra hour should be enough for builds.

@ordian ordian added the D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. label Mar 19, 2021
@TriplEight
Copy link
Contributor

I meant, in general. Are we good running fuzzing on rather weak public github hosts?

@ordian
Copy link
Author

ordian commented Mar 19, 2021

I meant, in general. Are we good running fuzzing on rather weak public github hosts?

Well, we want something working now. So I'd say it's good as is for now until we have more CI dev-time to borrow.

@TriplEight TriplEight self-requested a review March 19, 2021 16:59
@TriplEight
Copy link
Contributor

Everything looks good. Maybe give them a debug run before the merge?

Andronik Ordian added 5 commits March 19, 2021 18:33
* master:
  bump reed-solomon-novelpoly to v0.0.3 (#2650)
  restructure polkadot-node-jaeger (#2642)
This reverts commit 9759cb6.
Copy link
Contributor

@TriplEight TriplEight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ordian ordian merged commit ddb195a into master Mar 24, 2021
@ordian ordian deleted the ao-ci-fuzzer-jobs branch March 24, 2021 17:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.

Projects

None yet

Development

Successfully merging this pull request may close these issues.