Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Fix future-polling loop in availability and add a better early-exit #2779

Merged
rphmeier merged 3 commits into from
Mar 31, 2021
Merged

Fix future-polling loop in availability and add a better early-exit #2779

rphmeier merged 3 commits into from
Mar 31, 2021

Conversation

@rphmeier
Copy link
Contributor

@rphmeier rphmeier commented Mar 30, 2021

No description provided.

@rphmeier rphmeier added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Mar 30, 2021
drahnr
drahnr reviewed Mar 31, 2021
View reviewed changes
node/network/availability-recovery/src/tests.rs Outdated
Comment on lines 73 to 79
// let _ = env_logger::builder()
// .is_test(true)
// .filter(
// Some("polkadot_availability_recovery"),
// log::LevelFilter::Trace,
// )
// .try_init();
Copy link
Contributor

@drahnr drahnr Mar 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this accidentally committed?

@rphmeier
Copy link
Contributor Author

rphmeier commented Mar 31, 2021

bot merge

@ghost
Copy link

ghost commented Mar 31, 2021

Waiting for commit status.

@rphmeier rphmeier merged commit 9cdfd0c into master Mar 31, 2021
@rphmeier rphmeier deleted the rh-try-ready-availability branch March 31, 2021 15:35
ordian pushed a commit that referenced this pull request Mar 31, 2021
Merge branch 'master' into ao-fix-race-in-statement-distribution
fc506dd 
* master:
  proper executor/block type for benchmarks and try-runtime (#2771)
  Fix future-polling loop in availability and add a better early-exit (#2779)
ordian pushed a commit that referenced this pull request Mar 31, 2021
Merge branch 'master' into ao-do-no-try-to-connect-if-we-are-no-valid…
f78992a 
…ators

* master:
  statement-distribution: do not use OurViewChange (#2790)
  Better timeout values now that we are going to be connected to all nodes. (#2778)
  proper executor/block type for benchmarks and try-runtime (#2771)
  Fix future-polling loop in availability and add a better early-exit (#2779)
rphmeier added a commit that referenced this pull request Apr 1, 2021
@rphmeier
Fix future-polling loop in availability and add a better early-exit (#…
c1b7929 
…2779)

* onto the front

* fix early exit for waiting for requests

* add logging back
@stze stze added D1-audited 👍 PR contains changes to critical logic that has been properly reviewed and externally audited. and removed D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Sep 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@drahnr drahnr drahnr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D1-audited 👍 PR contains changes to critical logic that has been properly reviewed and externally audited. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rphmeier @drahnr @stze