Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Fix TransactAsset Implementation #3345

Merged
8 commits merged into from
Jul 26, 2021
Merged

Fix TransactAsset Implementation #3345

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a3f0c4a
convert local AssetNotFound errors into XcmError::AssetNotFound
apopiak Jun 22, 2021
189519a
add more XcmError descriptions
apopiak Jun 23, 2021
f5d5e92
adjust the rest of the TransactAsset tuple implementation to the beha…
apopiak Jun 23, 2021
f8855d1
fix copy paste errors
apopiak Jun 23, 2021
f7a8d57
Merge remote-tracking branch 'origin' into apopiak/asset-not-found
apopiak Jul 20, 2021
69e530d
keep iterating tuple on Unimplemented error in TransactAsset
apopiak Jul 21, 2021
1bb97cd
add tests for tuple implementation of TransactAsset
apopiak Jul 21, 2021
7520381
Update xcm/src/v0/traits.rs
shawntabrizi Jul 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
convert local AssetNotFound errors into XcmError::AssetNotFound 
aims allow the tuple implementation of TransactAsset to iterate properly
  • Loading branch information
@apopiak
apopiak committed Jun 22, 2021
commit a3f0c4a7fa8009fb00276a12eb9b73828c475887
2 changes: 1 addition & 1 deletion xcm/xcm-builder/src/currency_adapter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ impl From<Error> for XcmError {
fn from(e: Error) -> Self {
use XcmError::FailedToTransactAsset;
match e {
Error::AssetNotFound => FailedToTransactAsset("AssetNotFound"),
Error::AssetNotFound => XcmError::AssetNotFound,
Error::AccountIdConversionFailed => FailedToTransactAsset("AccountIdConversionFailed"),
Error::AmountToBalanceConversionFailed => FailedToTransactAsset("AmountToBalanceConversionFailed"),
}
Expand Down
2 changes: 1 addition & 1 deletion xcm/xcm-executor/src/traits/matches_fungibles.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ impl From<Error> for XcmError {
fn from(e: Error) -> Self {
use XcmError::FailedToTransactAsset;
match e {
Error::AssetNotFound => FailedToTransactAsset("AssetNotFound"),
Error::AssetNotFound => XcmError::AssetNotFound,
Error::AccountIdConversionFailed => FailedToTransactAsset("AccountIdConversionFailed"),
Error::AmountToBalanceConversionFailed => FailedToTransactAsset("AmountToBalanceConversionFailed"),
Error::AssetIdConversionFailed => FailedToTransactAsset("AssetIdConversionFailed"),
Expand Down