Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Companion PR for warp sync support. #3382

Merged
9 commits merged into from
Aug 2, 2021
Merged

Companion PR for warp sync support. #3382

9 commits merged into from
Aug 2, 2021

Conversation

@arkpar
Copy link
Member

@arkpar arkpar commented Jun 29, 2021

@arkpar arkpar added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Jun 29, 2021
@arkpar arkpar mentioned this pull request Jun 29, 2021
Merged
@arkpar arkpar requested a review from andresilva June 29, 2021 08:39
cheme
cheme approved these changes Aug 1, 2021
View reviewed changes
Copy link
Contributor

@cheme cheme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost
Copy link

ghost commented Aug 2, 2021

Error: Companion update failed: Command 'Command { std: "cargo" "update" "-vp" "sp-io", kill_on_drop: false }' failed with status Some(101); output: Updating git repository https://github.com/paritytech/substrate
Updating crates.io index
error: no matching package named sc-finality-grandpa-warp-sync found
location searched: https://github.com/paritytech/substrate?branch=master
required by package polkadot-service v0.9.8 (/builds/polkadot/node/service)

@arkpar
Copy link
Member Author

arkpar commented Aug 2, 2021

bot merge

@ghost
Copy link

ghost commented Aug 2, 2021

Waiting for commit status.

@ghost
Copy link

ghost commented Aug 2, 2021

Merge aborted: Checks failed for 56fc364

@arkpar
Copy link
Member Author

arkpar commented Aug 2, 2021

Blocked by #3549

@bkchr
Copy link
Member

bkchr commented Aug 2, 2021

@arkpar merged

@arkpar
Copy link
Member Author

arkpar commented Aug 2, 2021

bot merge

@ghost
Copy link

ghost commented Aug 2, 2021

Waiting for commit status.

@ghost ghost merged commit 4debdcd into master Aug 2, 2021
@ghost ghost deleted the a-warp-sync branch August 2, 2021 09:59
ordian pushed a commit that referenced this pull request Aug 2, 2021
Merge branch 'master' into ao-subsystem-do-not-use-ourviewchange
4093836 
* master:
  Companion PR for warp sync support. (#3382)
  Companion for #9373 (Refactor Benchmarks for Wasm Memory) (#3549)
  XCM simulator (#3538)
  Parachains scheduler.rs to FrameV2 (#3529)
  Parachains session_info.rs to FrameV2 (#3521)
  Companion for substrate #9319 (#3456)
@wilwade wilwade mentioned this pull request Jun 6, 2023
Closed
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andresilva andresilva Awaiting requested review from andresilva

2 more reviewers

@cheme cheme cheme approved these changes

@bkchr bkchr bkchr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@arkpar @bkchr @cheme