This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Guide updates for disputes. #3401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eskimor
added
A0-please_review
eskimor
force-pushed
the
rk-disputes-guide
branch
from
96d0e19 to
38f2ac0
Compare
pepyakin
reviewed
Jul 5, 2021
roadmap/implementers-guide/src/node/disputes/dispute-participation.md
Outdated
Show resolved
Hide resolved
…tion.md Co-authored-by: Sergei Shulepov <[email protected]>
rphmeier
reviewed
Jul 6, 2021
|
|
||
| Check DB for recorded votes for non concluded disputes we have not yet | ||
| recorded a local statement for. | ||
| For all of those send `DisputeParticipationMessage::Participate` message to |
rphmeier
reviewed
Jul 6, 2021
roadmap/implementers-guide/src/node/disputes/dispute-coordinator.md
Outdated
Show resolved
Hide resolved
rphmeier
reviewed
Jul 6, 2021
roadmap/implementers-guide/src/node/disputes/dispute-coordinator.md
Outdated
Show resolved
Hide resolved
rphmeier
reviewed
Jul 6, 2021
Comment on lines
+119
to
+121
| 13. If the dispute now has supermajority votes in the "invalid" direction, there | ||
| is no need to do anything explicitly. The actual rollback will be handled | ||
| during the active leaves update by observing digests from the runtime. |
Contributor
There was a problem hiding this comment.
This diff contains changes to 'active-disputes' so we make a distinction between "recent" (everything in DISPUTE_WINDOW, concluded or not) and "active" (subset of recent which is either not concluded or was concluded within some small amount of time)
Due to this, we actually never prune anything from active-disputes until it's purged by session age.
The motivation of the change in #3348 is to make sure the provisioner can still provide votes that are submitted shortly after conclusion to the on-chain logic. Those votes will be rewarded less than earlier ones.
Member
Author
Member
Author
|
@rphmeier - if it's fine with you, I would like to change plans and merge this now, as I am going to be on vacation tomorrow. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing review remarks of dispute distribution guide PR and integration of dispute distribution into other subsystems.