Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Improve MultiLocation conversion functions in xcm-procedural #3690

Merged
3 commits merged into from
Aug 23, 2021
Merged

Improve MultiLocation conversion functions in xcm-procedural #3690

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31a37be
Use fully-qualified paths to reference core traits in proc macro
KiChjang Aug 23, 2021
5478213
Ensure a canonicalized v0 MultiLocation first before attempting to co…
KiChjang Aug 23, 2021
9a3bf7e
Fix failing test
KiChjang Aug 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix failing test
  • Loading branch information
@KiChjang
KiChjang committed Aug 23, 2021
commit 9a3bf7eb0b4a8324727185ac5e80bcb747e09078
2 changes: 1 addition & 1 deletion xcm/src/v1/multilocation.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -895,7 +895,7 @@ mod tests {
);
assert_eq!(
v0::MultiLocation::X2(v0::Junction::Parachain(88), v0::Junction::Parent).try_into(),
Err::<MultiLocation, ()>(()),
Ok(MultiLocation::here()),
Copy link
Contributor

@kianenigma kianenigma Aug 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this not an error anymore? because of v0.canonicalize();?

Copy link
Contributor Author

@KiChjang KiChjang Aug 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, what results after canonicalization is exactly Here.

);
assert_eq!(
v0::MultiLocation::X3(
Expand Down