This repository was archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat/overseer: introduce closure init #3775
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables removal of the connected/disconnected overseer state.
Allows to re-use init-once types, which would otherwise error.
rphmeier
approved these changes
Sep 2, 2021
Preparation for removal of `AllSubsystems` which is another prerequisite for removing the connect/disconnect state.
This was referenced Sep 3, 2021
621c76a to
9c46653
Compare
ordian
approved these changes
Sep 3, 2021
Contributor
Author
|
bot merge |
|
Waiting for commit status. |
|
Merge aborted: Checks failed for 1563adf |
Contributor
Author
|
bot merge |
|
Waiting for commit status. |
ordian
pushed a commit
that referenced
this pull request
Sep 6, 2021
* master: Add tests and modify as_vec implementation (#3715) Bump structopt from 0.3.22 to 0.3.23 (#3770) bump substrate and beefy (#3789) set `DisputesHandler` in initializer (#3788) Bump futures from 0.3.16 to 0.3.17 (#3742) Convert rococo chainspec to raw chainspec (#3785) feat/overseer: introduce closure init (#3775) comment out bridges runtime modules (broken) and update Rococo chain-spec (#3780) Add VoteLocking config (#3734) Enable disputes on rococo (#3764) XCM: Automatic Version Negotiation (#3736)
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A3-in_progress
Pull request is in progress. No review needed at this stage.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables removal of the connected/disconnected overseer state.
remove connected / disconnected state trackingdeferred to overseer: removeconnect/disconnectstate of theHandle#3777 due to effortCloses #3771