Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
16ad36c
initial stuff
shawntabrizi Sep 27, 2021
cbd0dc8
Merge branch 'master' into shawntabrizi-xcm-generic-benchmarks
shawntabrizi Oct 4, 2021
82caeec
quick fixes
shawntabrizi Oct 4, 2021
e3a0f4a
move to individual tests
shawntabrizi Oct 4, 2021
f5b3269
dont need these
shawntabrizi Oct 4, 2021
29bfa5d
Update benchmarking.rs
shawntabrizi Oct 4, 2021
ec573a0
add to westend
shawntabrizi Oct 4, 2021
e3a7c02
Merge branch 'master' into shawntabrizi-xcm-generic-benchmarks
shawntabrizi Nov 11, 2021
77b1fbd
make benchmarks execute
shawntabrizi Nov 12, 2021
470ce15
fix compile
shawntabrizi Nov 14, 2021
82149ac
add post_execute
shawntabrizi Nov 15, 2021
b817e7c
ClaimAsset benchmark working
shawntabrizi Nov 15, 2021
3d9f774
subscribe and unsubscribe benchmarks
shawntabrizi Nov 15, 2021
e85c556
benchmark for initiate reserve withdraw
shawntabrizi Nov 15, 2021
e64c9ae
Merge branch 'master' into shawntabrizi-xcm-generic-benchmarks
shawntabrizi Nov 15, 2021
3aa3b3c
cargo run --quiet --release --features=runtime-benchmarks -- benchmar…
Nov 15, 2021
30c13a2
fix spell check
shawntabrizi Nov 15, 2021
270c283
Merge branch 'master' into shawntabrizi-xcm-generic-benchmarks
shawntabrizi Nov 15, 2021
041b3f4
Merge branch 'master' into shawntabrizi-xcm-generic-benchmarks
shawntabrizi Nov 15, 2021
cd190e2
cargo run --quiet --release --features=runtime-benchmarks -- benchmar…
Nov 15, 2021
2ee0d81
update worst case for query_holding
shawntabrizi Nov 16, 2021
02248db
Merge branch 'master' of https://github.com/paritytech/polkadot into …
Nov 16, 2021
a9a3b29
cargo run --quiet --release --features=runtime-benchmarks -- benchmar…
Nov 16, 2021
f51acc3
move verification logic below
shawntabrizi Nov 16, 2021
1e80cfe
introduce worst case holding to initiate reserve withdraw
shawntabrizi Nov 16, 2021
9178fbe
cargo run --quiet --release --features=runtime-benchmarks -- benchmar…
Nov 16, 2021
d8da46b
Merge branch 'master' into shawntabrizi-xcm-generic-benchmarks
shawntabrizi Nov 24, 2021
978b015
Merge branch 'master' into shawntabrizi-xcm-generic-benchmarks
shawntabrizi Nov 30, 2021
23602ca
feedback
shawntabrizi Nov 30, 2021
21fde67
Merge branch 'master' into shawntabrizi-xcm-generic-benchmarks
shawntabrizi Nov 30, 2021
2779039
cargo run --quiet --release --features=runtime-benchmarks -- benchmar…
Nov 30, 2021
98964be
Revert "cargo run --quiet --release --features=runtime-benchmarks -- …
shawntabrizi Nov 30, 2021
4939b63
fix benchmark template
shawntabrizi Nov 30, 2021
be2036d
cargo run --quiet --release --features=runtime-benchmarks -- benchmar…
Nov 30, 2021
4efd026
use response::version
shawntabrizi Dec 1, 2021
6c0ceed
Merge branch 'master' of https://github.com/paritytech/polkadot into …
Dec 1, 2021
77b183f
cargo run --quiet --release --features=runtime-benchmarks -- benchmar…
Dec 1, 2021
d783d40
refactor worst case holding
shawntabrizi Dec 1, 2021
2a9582b
Merge branch 'shawntabrizi-xcm-generic-benchmarks' of https://github.…
shawntabrizi Dec 1, 2021
6512a26
cargo run --quiet --release --features=runtime-benchmarks -- benchmar…
Dec 1, 2021
df66c1f
fmt
shawntabrizi Dec 1, 2021
fc51779
Merge branch 'shawntabrizi-xcm-generic-benchmarks' of https://github.…
shawntabrizi Dec 1, 2021
cd0f4b8
one more todo needs to be labeled
shawntabrizi Dec 1, 2021
b7e3ced
change option to result with benchmark error
shawntabrizi Dec 1, 2021
3c4dcb4
fmt and fix import
shawntabrizi Dec 1, 2021
a9ea6c1
Merge branch 'master' into shawntabrizi-xcm-generic-benchmarks
shawntabrizi Dec 1, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
make benchmarks execute
  • Loading branch information
shawntabrizi committed Nov 12, 2021
commit 77b1fbda43fcb4b8748b11e2a4c22d652d11fc2f
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ impl Requester {
// Just book keeping - we are already requesting that chunk:
{
e.get_mut().add_leaf(leaf);
}
},
Entry::Vacant(e) => {
let tx = self.tx.clone();
let metrics = self.metrics.clone();
Expand Down
2 changes: 1 addition & 1 deletion node/network/collator-protocol/src/validator_side/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1423,7 +1423,7 @@ async fn poll_collation_response(
);

CollationFetchResult::Error(COST_WRONG_PARA)
}
},
Ok(CollationFetchingResponse::Collation(receipt, pov)) => {
tracing::debug!(
target: LOG_TARGET,
Expand Down
2 changes: 1 addition & 1 deletion node/network/statement-distribution/src/tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1814,7 +1814,7 @@ fn peer_cant_flood_with_large_statements() {
if p == peer_a && r == COST_APPARENT_FLOOD =>
{
punished = true;
}
},

m => panic!("Unexpected message: {:?}", m),
}
Expand Down
4 changes: 4 additions & 0 deletions runtime/westend/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1567,6 +1567,10 @@ sp_api::impl_runtime_apis! {
fn worst_case_response() -> (u64, Response) {
(0u64, Default::default())
}

fn transact_origin() -> Option<MultiLocation> {
Some(Westmint::get())
}
}

type XcmBalances = pallet_xcm_benchmarks::fungible::Pallet::<Runtime>;
Expand Down
5 changes: 3 additions & 2 deletions xcm/pallet-xcm-benchmarks/src/generic/benchmarking.rs
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ benchmarks! {
let instruction = Instruction::ReserveAssetDeposited(multiassets.clone());
let xcm = Xcm(vec![instruction]);
}: {
executor.execute(xcm)?;
executor.execute(xcm).map_err(|_| BenchmarkError::Skip)?;
} verify {
assert_eq!(executor.holding, multiassets.into());
}
Expand All @@ -105,7 +105,8 @@ benchmarks! {
// and included in the final weight calculation. So this is just the overhead of submitting
// a noop call.
transact {
let mut executor = new_executor::<T>(Default::default());
let origin = T::transact_origin().ok_or(BenchmarkError::Skip)?;
let mut executor = new_executor::<T>(origin);
let noop_call: <T as Config>::Call = frame_system::Call::remark_with_event {
remark: Default::default()
}.into();
Expand Down
4 changes: 4 additions & 0 deletions xcm/pallet-xcm-benchmarks/src/generic/mock.rs
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,10 @@ impl generic::Config for Test {
let assets: MultiAssets = (Concrete(Here.into()), 100).into();
(0, Response::Assets(assets))
}

fn transact_origin() -> Option<MultiLocation> {
Some(Default::default())
}
}

pub fn new_test_ext() -> sp_io::TestExternalities {
Expand Down
4 changes: 3 additions & 1 deletion xcm/pallet-xcm-benchmarks/src/generic/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ mod mock;
#[frame_support::pallet]
pub mod pallet {
use frame_support::{dispatch::Dispatchable, pallet_prelude::Encode, weights::GetDispatchInfo};
use xcm::latest::Response;
use xcm::latest::{MultiLocation, Response};

#[pallet::config]
pub trait Config<I: 'static = ()>: frame_system::Config + crate::Config {
Expand All @@ -17,6 +17,8 @@ pub mod pallet {
+ Encode;

fn worst_case_response() -> (u64, Response);

fn transact_origin() -> Option<MultiLocation>;
}

#[pallet::pallet]
Expand Down