Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@ECJ222
Copy link
Contributor

@ECJ222 ECJ222 commented Nov 20, 2021

This is a Companion PR to paritytech/substrate#10296

skip check-dependent-cumulus

@ECJ222
Copy link
Contributor Author

ECJ222 commented Nov 24, 2021

please could you review this pr @athei and @kianenigma.

@ECJ222
Copy link
Contributor Author

ECJ222 commented Nov 25, 2021

Hi @athei, The CI keeps failing, please is there a way I can fix this?

@athei
Copy link
Member

athei commented Nov 25, 2021

The companion CI will always fail because it builds against the current substrate master which does not include your changes. Don't look at it.

You need to concentrate on making your substrate PR's CI green. The continuous-integration/gitlab-check-dependent-polkadot job there builds the polkadot companion against your PR. This is the one failing. This means that your companion (this PR) has build failures. So fix them and your substrate PR will get green. I can trigger the CI there once you made the changes here.

@ECJ222
Copy link
Contributor Author

ECJ222 commented Nov 25, 2021

Thank you @athei, I made a few changes to the initial pr I sent.

@athei athei added A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. and removed D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Nov 25, 2021
@bkchr
Copy link
Member

bkchr commented Nov 30, 2021

bot merge

@paritytech-processbot
Copy link

Error: Response error (status 404 Not Found):

{"documentation_url":"https://docs.github.com/rest/reference/pulls#get-a-pull-request","message":"Not Found"}

@bkchr bkchr merged commit 0043fe5 into paritytech:master Nov 30, 2021
drahnr pushed a commit that referenced this pull request Dec 1, 2021
* chore: update system event variants

* chore: update system event variants

* chore: modified event variants

* Update Substrate

Co-authored-by: Bastian Köcher <[email protected]>
drahnr pushed a commit that referenced this pull request Dec 1, 2021
* chore: update system event variants

* chore: update system event variants

* chore: modified event variants

* Update Substrate

Co-authored-by: Bastian Köcher <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants