This repository was archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[zombinet] initial implementation of zombienet backchannel #4377
Merged
Merged
Changes from 13 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
f9ef6b9
initial impl zombienet backchannel
pepoviola ce50d2f
clean code
pepoviola 46c25b3
changes from feedback
pepoviola 6a3b7c6
fmt and typo
pepoviola e6f73a1
remove default comment
pepoviola b3be116
refactor to use ws tx/rx
pepoviola b3eed29
fmt
pepoviola 91b6975
Merge branch 'master' into javier-zombienet-backchannel
pepoviola 5953051
derive Clone for ZombienetBackchannel
pepoviola e340d32
Revert "derive Clone for ZombienetBackchannel"
pepoviola 0ccb705
change tracing prefix value
pepoviola 39dae39
Merge branch 'master' into javier-zombienet-backchannel
pepoviola f3014e7
refactor backchannel
pepoviola 1558d42
Update node/zombienet-backchannel/Cargo.toml
pepoviola bd729ae
add docs to broadcaster methods
pepoviola 486794f
add more docs
pepoviola ed47fee
Merge branch 'master' into javier-zombienet-backchannel
pepoviola 16a7b99
fmt
pepoviola c83269d
Merge branch 'master' into javier-zombienet-backchannel
pepoviola 1e001cd
fix spellcheck
pepoviola d1e4223
update lock file
pepoviola 1a38285
remove unused
pepoviola e4d9dbc
fmt
pepoviola c5a0791
Merge branch 'master' into javier-zombienet-backchannel
pepoviola 9cda227
changes from feedback
pepoviola d14b7c8
fmt
pepoviola File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| [package] | ||
| name = "zombienet-backchannel" | ||
| description = "Zombienet backchannel to notify test runner and coordinate with malus actors." | ||
| license = "GPL-3.0-only" | ||
| version = "0.9.13" | ||
| authors = ["Parity Technologies <[email protected]>"] | ||
| edition = "2018" | ||
| readme = "README.md" | ||
| publish = false | ||
|
|
||
| [dependencies] | ||
| tokio = { version = "1.0.0", default-features = false, features = ["macros", "net", "rt-multi-thread", "sync"] } | ||
| url = "2.0.0" | ||
| tokio-tungstenite = "0.16" | ||
| futures-util = "0.3.18" | ||
| lazy_static = "1.4.0" | ||
| parity-scale-codec = { version = "2.3.1", features = ["derive"] } | ||
| reqwest = "0.11" | ||
| thiserror = "1.0.30" | ||
| tracing = "0.1.26" | ||
| serde = { version = "1.0", features = ["derive"] } | ||
| serde_json = "1" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| // Copyright 2021 Parity Technologies (UK) Ltd. | ||
| // This file is part of Polkadot. | ||
|
|
||
| // Polkadot is free software: you can redistribute it and/or modify | ||
| // it under the terms of the GNU General Public License as published by | ||
| // the Free Software Foundation, either version 3 of the License, or | ||
| // (at your option) any later version. | ||
|
|
||
| // Polkadot is distributed in the hope that it will be useful, | ||
| // but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| // GNU General Public License for more details. | ||
|
|
||
| // You should have received a copy of the GNU General Public License | ||
| // along with Polkadot. If not, see <http://www.gnu.org/licenses/>. | ||
|
|
||
| //! Polkadot Zombienet Backchannel error definitions. | ||
|
|
||
| #[derive(Debug, thiserror::Error)] | ||
| #[allow(missing_docs)] | ||
| pub enum BackchannelError { | ||
| #[error("Error connecting websocket server")] | ||
| CantConnectToWS, | ||
|
|
||
| #[error("Backchannel not initialized yet")] | ||
| Uninitialized, | ||
|
|
||
| #[error("Backchannel already initialized")] | ||
| AlreadyInitialized, | ||
|
|
||
| #[error("Error sending new value to backchannel")] | ||
| SendItemFail, | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,154 @@ | ||
| // Copyright 2017-2021 Parity Technologies (UK) Ltd. | ||
| // This file is part of Polkadot. | ||
|
|
||
| // Polkadot is free software: you can redistribute it and/or modify | ||
| // it under the terms of the GNU General Public License as published by | ||
| // the Free Software Foundation, either version 3 of the License, or | ||
| // (at your option) any later version. | ||
|
|
||
| // Polkadot is distributed in the hope that it will be useful, | ||
| // but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| // GNU General Public License for more details. | ||
|
|
||
| // You should have received a copy of the GNU General Public License | ||
| // along with Polkadot. If not, see <http://www.gnu.org/licenses/>. | ||
|
|
||
| //! Provides the possibility to coordination between malicious actors and | ||
| //! the zombienet test-runner, allowing to reference runtime's generated | ||
| //! values in the test specifications, through a bidirectional message passing | ||
| //! implemented as a `backchannel`. | ||
|
|
||
| use futures_util::{stream::SplitSink, SinkExt, StreamExt}; | ||
| use lazy_static::lazy_static; | ||
| use parity_scale_codec as codec; | ||
| use serde::{Deserialize, Serialize}; | ||
| use std::env; | ||
| use std::sync::Mutex; | ||
| use tokio::{net::TcpStream, sync::broadcast}; | ||
| use tokio_tungstenite::{ | ||
| connect_async, tungstenite::protocol::Message, MaybeTlsStream, WebSocketStream, | ||
| }; | ||
|
|
||
| mod errors; | ||
| use errors::BackchannelError; | ||
|
|
||
| lazy_static! { | ||
| pub static ref ZOMBIENET_BACKCHANNEL: Mutex<Option<ZombienetBackchannel>> = Mutex::new(None); | ||
| } | ||
|
|
||
| #[derive(Debug)] | ||
| pub struct ZombienetBackchannel { | ||
| broadcast_tx: broadcast::Sender<BackchannelItem>, | ||
| ws_tx: broadcast::Sender<BackchannelItem>, | ||
| } | ||
|
|
||
| #[derive(Clone, Debug, Serialize, Deserialize)] | ||
| pub struct BackchannelItem { | ||
| key: String, | ||
| value: String, | ||
| } | ||
|
|
||
| pub struct Broadcaster; | ||
|
|
||
| pub const ZOMBIENET: &str = "🧟ZOMBIENET🧟"; | ||
|
|
||
| impl Broadcaster { | ||
| pub fn subscribe(&self) -> Result<broadcast::Receiver<BackchannelItem>, BackchannelError> { | ||
pepoviola marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| let mut zombienet_bkc = ZOMBIENET_BACKCHANNEL.lock().unwrap(); | ||
| let sender = zombienet_bkc.as_mut().unwrap().broadcast_tx.clone(); | ||
pepoviola marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| if zombienet_bkc.is_some() { | ||
| Ok(sender.subscribe()) | ||
| } else { | ||
| Err(BackchannelError::Uninitialized) | ||
| } | ||
| } | ||
|
|
||
| pub async fn send( | ||
| &mut self, | ||
| key: &'static str, | ||
| val: impl codec::Encode, | ||
| ) -> Result<(), BackchannelError> { | ||
| let mut zombienet_bkc = ZOMBIENET_BACKCHANNEL.lock().unwrap(); | ||
| if zombienet_bkc.is_none() { | ||
| return Err(BackchannelError::Uninitialized); | ||
| } | ||
| let encoded = val.encode(); | ||
| let backchannel_item = BackchannelItem { | ||
| key: key.to_string(), | ||
| value: String::from_utf8_lossy(&encoded).to_string(), | ||
| }; | ||
|
|
||
| let sender = zombienet_bkc.as_mut().unwrap().ws_tx.clone(); | ||
pepoviola marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| sender.send(backchannel_item).map_err(|e| { | ||
| tracing::error!(target = ZOMBIENET, "Error sending new item: {}", e); | ||
| BackchannelError::SendItemFail | ||
| })?; | ||
|
|
||
| Ok(()) | ||
| } | ||
| } | ||
|
|
||
| impl ZombienetBackchannel { | ||
| pub async fn init() -> Result<(), BackchannelError> { | ||
| let mut zombienet_bkc = ZOMBIENET_BACKCHANNEL.lock().unwrap(); | ||
| if zombienet_bkc.is_none() { | ||
| let backchannel_host = | ||
| env::var("BACKCHANNEL_HOST").unwrap_or_else(|_| "backchannel".to_string()); | ||
| let backchannel_port = | ||
| env::var("BACKCHANNEL_PORT").unwrap_or_else(|_| "3000".to_string()); | ||
pepoviola marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| let ws_url = format!("ws://{}:{}/ws", backchannel_host, backchannel_port); | ||
| tracing::debug!(target = ZOMBIENET, "Connecting to : {}", &ws_url); | ||
| let (ws_stream, _) = | ||
| connect_async(ws_url).await.map_err(|_| BackchannelError::CantConnectToWS)?; | ||
| let (mut write, mut read) = ws_stream.split(); | ||
|
|
||
| let (tx, _rx) = broadcast::channel(256); | ||
| let (tx_relay, mut rx_relay) = broadcast::channel::<BackchannelItem>(256); | ||
|
|
||
| // receive from the ws and send to all subcribers | ||
| let tx1 = tx.clone(); | ||
| tokio::spawn(async move { | ||
| while let Some(Ok(Message::Text(text))) = read.next().await { | ||
| match serde_json::from_str::<BackchannelItem>(&text) { | ||
| Ok(backchannel_item) => { | ||
| if tx1.send(backchannel_item).is_err() { | ||
| tracing::error!("Error sending through the channel"); | ||
| return; | ||
| } | ||
| } | ||
| Err(_) => { | ||
| tracing::error!("Invalid payload received"); | ||
| } | ||
| } | ||
| } | ||
| }); | ||
|
|
||
| // receive from subscribers and relay to ws | ||
| tokio::spawn(async move { | ||
| while let Ok(item) = rx_relay.recv().await { | ||
| if write | ||
| .send(Message::Text(serde_json::to_string(&item).unwrap())) | ||
| .await | ||
| .is_err() | ||
| { | ||
| tracing::error!("Error sending through ws"); | ||
| } | ||
| } | ||
| }); | ||
|
|
||
| *zombienet_bkc = Some(ZombienetBackchannel { broadcast_tx: tx, ws_tx: tx_relay }); | ||
| return Ok(()); | ||
| } | ||
|
|
||
| Err(BackchannelError::AlreadyInitialized) | ||
| } | ||
|
|
||
pepoviola marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| pub fn broadcaster() -> Result<Broadcaster, BackchannelError> { | ||
| if ZOMBIENET_BACKCHANNEL.lock().unwrap().is_some() { | ||
| Ok(Broadcaster {}) | ||
| } else { | ||
| Err(BackchannelError::Uninitialized) | ||
| } | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.