Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Remove sleep from tests #4639

Merged
paritytech-processbot merged 19 commits into from
Jan 10, 2022
Merged

Remove sleep from tests #4639

paritytech-processbot merged 19 commits into from
Jan 10, 2022

Conversation

@sandreim
Copy link
Contributor

@sandreim sandreim commented Dec 29, 2021 •
edited
Loading

Fixes #4622

WIP

Duplicates some Susbtrate testing utility code. Tracking this in paritytech/substrate#10591

cumulus companion: paritytech/cumulus#890

@github-actions github-actions bot added the A3-in_progress Pull request is in progress. No review needed at this stage. label Dec 29, 2021
@sandreim sandreim added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Dec 29, 2021
sandreim
sandreim commented Jan 5, 2022
View reviewed changes
@sandreim sandreim added the A0-please_review Pull request needs code review. label Jan 5, 2022
@sandreim sandreim marked this pull request as ready for review January 5, 2022 15:54
@sandreim sandreim requested review from a team and chevdor as code owners January 5, 2022 15:54
@sandreim sandreim requested a review from ordian January 5, 2022 15:54
@sandreim sandreim changed the title Remove sleep from test Remove sleep from tests Jan 5, 2022
@sandreim sandreim mentioned this pull request Jan 6, 2022
Merged
ordian
ordian reviewed Jan 7, 2022
View reviewed changes
Copy link

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.

drahnr
drahnr approved these changes Jan 7, 2022
View reviewed changes
Copy link
Contributor

@drahnr drahnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit, other than that, looks good to me.

drahnr
drahnr reviewed Jan 7, 2022
View reviewed changes
sandreim and others added 5 commits January 7, 2022 21:42
@sandreim
cargo
e8ffe40 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
Polkadot companion for Substrate#10463 (#4519)
07015b2 
* Grandpa and Beefy protocol names include chain id

Signed-off-by: acatangiu <[email protected]>

* chain_spec: include fork id

* use simplified protocol name

* fix after merge

* avoid using hash default, even for protocol names

* update lockfile for substrate

Co-authored-by: parity-processbot <>
@pepyakin @sandreim
configuration: Update upgrade validation delay doc (#4662)
bff9bfd
@sandreim
typo
1d85941 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
review feedback
4715e83 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
cargo lock
5f96e27 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim sandreim force-pushed the sandreim/remove_sleep branch from 96c2706 to 5f96e27 Compare January 7, 2022 21:52
@sandreim sandreim requested a review from ordian January 8, 2022 13:33
drahnr
drahnr reviewed Jan 10, 2022
View reviewed changes
@drahnr
Copy link
Contributor

drahnr commented Jan 10, 2022

bot merge

@paritytech-processbot
Copy link

paritytech-processbot bot commented Jan 10, 2022

Error: Response error (status 404 Not Found): 

{"documentation_url":"https://docs.github.com/rest/reference/repos#get-repository-content","message":"Not Found"}

@sandreim
Copy link
Contributor Author

sandreim commented Jan 10, 2022

Still needs review from CI team.

sergejparity
sergejparity approved these changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@sergejparity sergejparity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI part looks good

@sandreim
Copy link
Contributor Author

sandreim commented Jan 10, 2022

bot merge

@paritytech-processbot
Copy link

paritytech-processbot bot commented Jan 10, 2022

Error: It's not possible to meet the minimal approval count of 1 in paritytech/cumulus#890

@sandreim
Copy link
Contributor Author

sandreim commented Jan 10, 2022

bot merge

@paritytech-processbot paritytech-processbot bot merged commit adf3c59 into master Jan 10, 2022
@paritytech-processbot paritytech-processbot bot deleted the sandreim/remove_sleep branch January 10, 2022 11:00
@joao-paulo-parity joao-paulo-parity mentioned this pull request Jan 10, 2022
Closed
@ordian ordian mentioned this pull request Jan 11, 2022
Closed
Wizdave97 pushed a commit to ComposableFi/polkadot that referenced this pull request Feb 3, 2022
@sandreim @pepyakin @Wizdave97
Remove sleep from tests (paritytech#4639)
1c5ceb6 
* Remove sleep and use polkadot test service

Signed-off-by: Andrei Sandu <[email protected]>

* updates

Signed-off-by: Andrei Sandu <[email protected]>

* Fix other tests

Signed-off-by: Andrei Sandu <[email protected]>

* Run metrics tests separately

Signed-off-by: Andrei Sandu <[email protected]>

* copy some substrate utilities

Signed-off-by: Andrei Sandu <[email protected]>

* update runtime metric test

Signed-off-by: Andrei Sandu <[email protected]>

* Remove sleep from cli tests

Signed-off-by: Andrei Sandu <[email protected]>

* cargo

Signed-off-by: Andrei Sandu <[email protected]>

* Polkadot companion for Substrate#10463 (paritytech#4519)

* Grandpa and Beefy protocol names include chain id

Signed-off-by: acatangiu <[email protected]>

* chain_spec: include fork id

* use simplified protocol name

* fix after merge

* avoid using hash default, even for protocol names

* update lockfile for substrate

Co-authored-by: parity-processbot <>

* configuration: Update upgrade validation delay doc (paritytech#4662)

* typo

Signed-off-by: Andrei Sandu <[email protected]>

* review feedback

Signed-off-by: Andrei Sandu <[email protected]>

* cargo lock

Signed-off-by: Andrei Sandu <[email protected]>

* use testnet profile

Signed-off-by: Andrei Sandu <[email protected]>

* Don't run with runtime-benchmark feature

Signed-off-by: Andrei Sandu <[email protected]>

* conditional compile up one level

Signed-off-by: Andrei Sandu <[email protected]>

Co-authored-by: Sergei Shulepov <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chevdor chevdor Awaiting requested review from chevdor

5 more reviewers

@bkchr bkchr bkchr left review comments

@drahnr drahnr drahnr approved these changes

@ordian ordian ordian approved these changes

@alvicsam alvicsam alvicsam approved these changes

@sergejparity sergejparity sergejparity approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove sleep from runtime_can_publish_metrics and purge_chain_works tests

8 participants

@sandreim @drahnr @ordian @bkchr @alvicsam @sergejparity @pepyakin