Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@stanly-johnson
Copy link
Contributor

resolves #4648

@bkchr bkchr requested a review from pepyakin February 27, 2022 19:36
Copy link
Contributor

@pepyakin pepyakin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks,

One thing that we could be done here or in a follow-up is to see if we can remove this function from paras_sudo_wrapper to avoid duplication.

@joepetrowski
Copy link
Contributor

Would be nice to pass the deposits into {init, accept}_open_channel so that channels opened by Root don't need a deposit. It would remove the need to transfer from the Treasury, and makes sense given that governance is the spam-limiting means.

@gilescope gilescope added A0-please_review Pull request needs code review. B1-releasenotes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels May 17, 2022
@hbulgarini
Copy link

@stanly-johnson , do you think that you can address this comment from joe? I think this feature will very simplify the usage for opening hrmp channels.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Root call to open / accept / establish HRMP channel

7 participants