This repository was archived by the owner on Nov 15, 2023. It is now read-only.
update mick jaeger and add some sanity unit tests #5067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drahnr
force-pushed
the
bernhard-jaeger-utests
branch
from
910da2d to
899d7a5
Compare
drahnr
force-pushed
the
bernhard-jaeger-utests
branch
from
899d7a5 to
a7c254e
Compare
drahnr
added
B0-silent
drahnr
changed the title
drahnr
force-pushed
the
bernhard-jaeger-utests
branch
2 times, most recently
from
976efa6 to
da1cbfe
Compare
sandreim
approved these changes
Mar 10, 2022
Contributor
sandreim
left a comment
sandreim
left a comment
There was a problem hiding this comment.
The added unit tests are failing, but otherwise LGTM.
drahnr
force-pushed
the
bernhard-jaeger-utests
branch
2 times, most recently
from
fa8e312 to
4bb8d62
Compare
drahnr
changed the title
drahnr
force-pushed
the
bernhard-jaeger-utests
branch
from
4bb8d62 to
316e8a6
Compare
Lldenaurois
approved these changes
Mar 10, 2022
Contributor
Lldenaurois
left a comment
Lldenaurois
left a comment
There was a problem hiding this comment.
Ran tests and everything looks good.
Contributor
Author
|
bot merge |
|
Waiting for commit status. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the investigation related to #5045
Verifies the correctness of the
TraceIDgeneration.CC @lazam once this is merged, we should be good to check if the identifiers are now truely working.