Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@andresilva
Copy link
Contributor

No description provided.

@andresilva andresilva added the A0-please_review Pull request needs code review. label Oct 29, 2019
@andresilva andresilva requested a review from gavofyork October 29, 2019 21:43
@andresilva andresilva changed the title bump version to 0.6.5 bump version to 0.6.6 Oct 29, 2019
@andresilva andresilva force-pushed the andre/bump-version-0.6.5 branch from 1de27a7 to 4dd0b2f Compare October 29, 2019 21:52
@bkchr bkchr merged commit fbcc9b1 into master Oct 30, 2019
@bkchr bkchr deleted the andre/bump-version-0.6.5 branch October 30, 2019 09:48
gavofyork pushed a commit that referenced this pull request Oct 31, 2019
gavofyork added a commit that referenced this pull request Oct 31, 2019
* bump version to 0.6.6 (#516)

* retry on gitlab system failures (#521)

* retry on gitlab system failures

* max is just 2

* Bump Substrate master (#522)

* Bump substrate

* Bump runtime version

* Fix Configuration stuff

* fix extract_proof return type

* add ImOnline module as Authorship event handler
tomusdrw pushed a commit that referenced this pull request Mar 26, 2021
imstar15 pushed a commit to imstar15/polkadot that referenced this pull request Aug 25, 2021
* Propose bumping StringLimit to 64 bytes

The StringLimit of 50 bytes is too short for useful hashes of different protocols:

- When using IPFS, the hash is 46 bytes. With a protocol prefix and type prefix (IPFS vs IPNS) it becomes: `ipfs://ipfs/QmPK1s3pNYLi9ERiq3BDxKa4XosgWwFRQUydHUtz4YgpqB` or 59 bytes.
- On arweave, the hash is 43 bytes. Prefixed with just `arweave://` bumps it up to 53: `arweave://BNttzDav3jHVnNiV7nYbQv-GY0HQ-4XXsdkE5K9ylHQ`.
- On Sia, with 46 char hashes, adding `sia://` as the protocol to use will bump it past 50: `sia://GACjmEWXmYF1N3Rc-PyjN304-8M0zOXHYzAXY9222xkGhA` (52)

As such, we feel that 64 bytes is a reasonable minimum for the `StringLimit`.

* Update lib.rs

* Add different const for `UniquesStringLimit`

Co-authored-by: Shawn Tabrizi <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants