This repository was archived by the owner on Nov 15, 2023. It is now read-only.
add comments for WonRenewal event #533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
We should just update the runtime logic here to make it consistent ordering imo. |
gavofyork
approved these changes
Nov 5, 2019
Member
|
will need backporting to v0.6 branch. |
xlc
added a commit
to xlc/polkadot
that referenced
this pull request
Nov 7, 2019
* add comments for WonRenewal event * make event argument order consistent
gavofyork
pushed a commit
that referenced
this pull request
Nov 8, 2019
tomusdrw
pushed a commit
that referenced
this pull request
Mar 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think this is intended but for
WonRenewalthe first balance is total, second is extra and forReservedthe first is extra and second istotal. This is confusing.