Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

add PR guideline, update CONTRIBUTING.md, move spellcheck #5390

Closed
wants to merge 8 commits into from
Closed

add PR guideline, update CONTRIBUTING.md, move spellcheck #5390

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4ab0202
move cargo-spellcheck related files back to the default pickup path
drahnr Apr 25, 2022
f7303bb
update CONTRIBUTING.md
drahnr Apr 25, 2022
ff4ea87
add PR template
drahnr Apr 25, 2022
e94efb6
lint
drahnr Apr 25, 2022
bdf3752
Update .github/PULL_REQUEST_TEMPLATE.md
drahnr Apr 25, 2022
cea43ed
Update CONTRIBUTING.md
drahnr Apr 26, 2022
0d5b720
add ADR.md
drahnr Apr 26, 2022
d4263fe
make sure these commands are optional
drahnr Apr 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
make sure these commands are optional
  • Loading branch information
@drahnr
drahnr committed Apr 26, 2022
commit d4263fefe38fd9d912bb944694d45d0052e715ec
11 changes: 6 additions & 5 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,12 @@ Apply labels!
## Checklist

- [ ] Labels applied correctly? See the [contributing guidlines](../CONTRIBUTING.md).
Copy link
Contributor

@pepyakin pepyakin Apr 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

External contributors cannot apply labels.

- [ ] Workspace compiles `cargo check --workspace --tests`?
- [ ] Workspace tests `cargo test --workspace`?
- [ ] Applied `cargo +nightly fmt` with the version from CI?
- [ ] Ran `cargo spellcheck` without any fallout? If any, update `.spellcheck/lingua.dic`.
- [ ] Fixed any fallout caused by these changes in `cumulus`?
- [ ] Iterate using the CI, or run the following commands on your setup iff it's beefy enough (optional):
- [ ] Workspace compiles `cargo check --workspace --tests`?
- [ ] Workspace tests `cargo test --workspace`?
- [ ] Applied `cargo +nightly fmt` with the version from CI?
- [ ] Ran `cargo spellcheck` without any fallout? If any, update `.spellcheck/lingua.dic`.
- [ ] Fixed any fallout caused by this PR in `cumulus`?
- [ ] Referenced relevant companion pull-requests of `substrate` and `cumulus`?
- [ ] Does the change mandate an [architecture decision record](../ADR.md) being added?

Expand Down