This repository was archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
companion for #11395 #5499
Merged
Merged
companion for #11395 #5499
+189
−189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e91ef1e to
fd49e36
Compare
coderobe
approved these changes
May 11, 2022
jsdw
approved these changes
May 11, 2022
bkchr
previously requested changes
May 11, 2022
Member
bkchr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing the call to the health_api?
|
Waiting for commit status. |
Contributor
Author
No substrate is doing it out under the hood when calling the substrate service (which internally is starting the servers with the health API enabled not possible to opt-out). I can add a test for this if you like. |
|
Merge cancelled due to error. Error: Checks failed for de1517b |
lexnv
approved these changes
May 11, 2022
lexnv
approved these changes
May 11, 2022
Contributor
Author
|
bot merge |
|
Error: Statuses failed for de1517b |
niklasad1
added a commit
that referenced
this pull request
May 11, 2022
* companion for 11395
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
coderobe
pushed a commit
that referenced
this pull request
May 11, 2022
* update substrate * companion for #11395 (#5499) * companion for 11395 * update lockfile for {"substrate"} Co-authored-by: parity-processbot <>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cumulus companion: paritytech/cumulus#1253