Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@niklasad1
Copy link
Contributor

@niklasad1 niklasad1 commented May 11, 2022

cumulus companion: paritytech/cumulus#1253

@niklasad1 niklasad1 force-pushed the na-companion-11395 branch from e91ef1e to fd49e36 Compare May 11, 2022 10:10
bkchr
bkchr previously requested changes May 11, 2022
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing the call to the health_api?

@paritytech-processbot
Copy link

Waiting for commit status.

@bkchr bkchr dismissed their stale review May 11, 2022 10:40

🤦

@niklasad1
Copy link
Contributor Author

niklasad1 commented May 11, 2022

This is missing the call to the health_api?

No substrate is doing it out under the hood when calling the substrate service (which internally is starting the servers with the health API enabled not possible to opt-out).

I can add a test for this if you like.

@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Checks failed for de1517b

@niklasad1 niklasad1 added the B0-silent Changes should not be mentioned in any release notes label May 11, 2022
@niklasad1 niklasad1 added C1-low PR touches the given topic and has a low impact on builders. and removed A0-please_review Pull request needs code review. labels May 11, 2022
@niklasad1
Copy link
Contributor Author

bot merge

@paritytech-processbot
Copy link

Error: Statuses failed for de1517b

@niklasad1 niklasad1 merged commit 6ed790b into master May 11, 2022
@niklasad1 niklasad1 deleted the na-companion-11395 branch May 11, 2022 12:24
niklasad1 added a commit that referenced this pull request May 11, 2022
* companion for 11395

* update lockfile for {"substrate"}

Co-authored-by: parity-processbot <>
coderobe pushed a commit that referenced this pull request May 11, 2022
* update substrate

* companion for #11395 (#5499)

* companion for 11395

* update lockfile for {"substrate"}

Co-authored-by: parity-processbot <>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants