This repository was archived by the owner on Nov 15, 2023. It is now read-only.
overseer becomes orchestra #5542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
A3-in_progress
drahnr
force-pushed
the
bernhard-overseer-becomes-orchestra
branch
from
e7b3b96 to
5f18713
Compare
drahnr
added
B0-silent
Also drop `gum` and use `tracing`.
Finalizes the independence of orchestra from polkadot-overseer
drahnr
force-pushed
the
bernhard-overseer-becomes-orchestra
branch
from
5f18713 to
a8a81a5
Compare
tdimitrov
approved these changes
May 19, 2022
vstakhov
approved these changes
May 19, 2022
Contributor
vstakhov
left a comment
vstakhov
left a comment
There was a problem hiding this comment.
I'd suggest some small neats.
Co-authored-by: Vsevolod Stakhov <[email protected]>
Co-authored-by: Vsevolod Stakhov <[email protected]>
sandreim
approved these changes
May 19, 2022
Contributor
sandreim
left a comment
sandreim
left a comment
There was a problem hiding this comment.
Nit: file names still reference overseer - node/overseer/orchestra/proc-macro/src/parse/parse_overseer_struct.rs. Otherwise LGTM.
Bumps [scale-info](https://github.com/paritytech/scale-info) from 2.1.1 to 2.1.2. - [Release notes](https://github.com/paritytech/scale-info/releases) - [Changelog](https://github.com/paritytech/scale-info/blob/master/CHANGELOG.md) - [Commits](paritytech/scale-info@v2.1.1...v2.1.2) --- updated-dependencies: - dependency-name: scale-info dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…anion for Substrate#11232) (#5337) * Switch to pooling copy-on-write instantiation strategy for WASM * Fix compilation of `polkadot-test-service` * Update comments * Move `max_memory_size` to `Semantics` * Rename `WasmInstantiationStrategy` to `WasmtimeInstantiationStrategy` * Update a safety comment * update lockfile for {"substrate"} Co-authored-by: parity-processbot <>
Contributor
Author
|
bot merge |
|
Waiting for commit status. |
|
Merge cancelled due to error. Error: Statuses failed for ba313b7 |
ordian
reviewed
May 19, 2022
| "node/overseer/overseer-gen", | ||
| "node/overseer/overseer-gen/proc-macro", | ||
| "node/overseer/orchestra", | ||
| "node/overseer/orchestra/proc-macro", |
There was a problem hiding this comment.
so now we have overseer and orchestra :P
Contributor
Author
There was a problem hiding this comment.
The overseer is the polkadot specific (package polkadot-overseer) where orchestra is the framework which was previously overseer-gen (and overseer-gen-proc-macro).
And a few types are leaking still, but that's a thing for another PR to add proper pub use FromOrchestra as FromOverseer; (i.e.) for consistency to create proper abstraction layers. Halfway there 💦
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
metered-channeltoprioritized-metered-channel, not part of this PR, required for crates-io publishing, but also Avoid using unbounded channels for prioritization polkadot-sdk#824overlordtoorchestraOverseersuffixed/prefixed types to beOrchestrasuffixed/prefixed, i.e.FromOverseer->FromOrchestra,ToOrchestra,OrchestraErroretctrait SpawnNamedcaused some trouble here, which requiredstruct SpawnGlue<S: SpawnNamed>being introduced to bridge thesc_core::traits::SpawnNamedwith thetrait orchestra::Spawnerwhich are both foreign topolkadot-overseer. Currently this type is leaked, but should be eventually be hidden inside theTestContextand friends, such that inpolkadot-overseeronlyS: SpawnNamedexists and are the converted internally (I leave this open what it exactly means, at this point in time within theOverseerGenand helperfns). This is an integration beauty issue and not so much a reason to delay the merge of this PR.