Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

[orchestra] extract graph logic and enhance with cycle detection + coloring #5614

Merged
paritytech-processbot merged 18 commits into from
Jun 6, 2022
Merged

[orchestra] extract graph logic and enhance with cycle detection + coloring #5614

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
a3bc780
extract graph
drahnr May 30, 2022
7ada8d0
move into scope
drahnr May 30, 2022
bca69d9
remove dead code
drahnr May 30, 2022
7fde418
add special nodes
drahnr May 30, 2022
a60a3ba
avoid some clones
drahnr May 31, 2022
841792d
better doc
drahnr May 31, 2022
7ec0f15
maybe better to use ✨
drahnr May 31, 2022
3827977
print all cycles, or an error
drahnr May 31, 2022
116f79f
don't print tiny cycles, if there is nothing to unvisited anymore, th…
drahnr May 31, 2022
1dbda9e
make print better
drahnr May 31, 2022
92cb119
fmt ffs
drahnr May 31, 2022
b8e875d
correct: cycle -> scc
drahnr Jun 1, 2022
372a167
fix loop exit condition
drahnr Jun 1, 2022
b98b419
add a test for kosaraju behavior
drahnr Jun 1, 2022
bd08672
unify on 'component'
drahnr Jun 3, 2022
1b05f47
disable graph by default
drahnr Jun 3, 2022
c3b0d43
chore: fmt
drahnr Jun 3, 2022
e058139
move graph only to graph_helpers
drahnr Jun 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
disable graph by default 
https://github.com/paritytech/ci_cd/issues/433
  • Loading branch information
@drahnr
drahnr authored Jun 3, 2022
commit 1b05f4722b58b66c8943845fbd3a1364167d5108
2 changes: 1 addition & 1 deletion node/orchestra/proc-macro/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ thiserror = "1"
tracing = "0.1"

[features]
default = ["graph"]
default = [] # enable "graph" by default, blocked by <https://github.com/paritytech/ci_cd/issues/433>
# write the expanded version to a `orchestra-expansion.[a-f0-9]{10}.rs`
# in the `OUT_DIR` as defined by `cargo` for the `expander` crate.
expand = []
Expand Down