This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Companion for substrate#11302 #5667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresilva
added
A2-insubstantial
andresilva
requested review from
acatangiu,
svyatonik and
tomusdrw
as code owners
Contributor
Author
|
@svyatonik I had to make some changes to some of the bridges tests. The behavior of |
andresilva
commented
Jun 13, 2022
| #[test] | ||
| fn same_result_when_justification_contains_duplicate_vote() { | ||
| let mut justification = make_default_justification(&test_header(1)); | ||
| let mut justification = make_justification_for_header(JustificationGeneratorParams { |
Contributor
Author
There was a problem hiding this comment.
The default justification sets ancestors: 2 which means that e.g. the precommits finalize block #3 while the commit says that the target finalized block is #1.
Contributor
There was a problem hiding this comment.
Thank you! I'll fix it upstream! BTW - we'll probably removed bridges subtree from polkadot repo soon, so you won't need to fix our code anymore.
bkchr
approved these changes
Jun 14, 2022
koute
approved these changes
Jun 14, 2022
|
Waiting for commit status. |
al3mart
pushed a commit
that referenced
this pull request
Jul 14, 2022
* bridges: bump finality-grandpa version
* bridges: fix tests
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
paritytech/substrate#11302