This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Update metric before bailing out #5706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrei Sandu <[email protected]>
github-actions
bot
added
the
A3-in_progress
sandreim
added
B1-releasenotes
C1-low
ordian
reviewed
Jun 21, 2022
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
ordian
approved these changes
Jun 21, 2022
github-actions
bot
added
A0-please_review
sandreim
added
B0-silent
vstakhov
approved these changes
Jun 22, 2022
Contributor
vstakhov
left a comment
vstakhov
left a comment
There was a problem hiding this comment.
Looks good in general, some minor neats might be applied if relevant
Signed-off-by: Andrei Sandu <[email protected]>
Contributor
Author
|
bot merge |
ordian
pushed a commit
that referenced
this pull request
Jun 28, 2022
* master: zombienet: try to fix parachains upgrade test (#5724) Update dependencies (companion for substrate#11722) (#5731) Update metric name and doc (#5716) Bump reqwest from 0.11.10 to 0.11.11 (#5732) add release-engineering to CI files' reviewers (#5733) Bump parity-scale-codec from 3.1.2 to 3.1.5 (#5720) Add checklist item (#5715) Fix 5560: add support for a new `staking-miner info` command (#5577) Bump `wasmtime` to 0.38.0 and `zstd` to 0.11.2 (companion for substrate#11720) (#5707) pvf: ensure enough stack space (#5712) Bump generic-array from 0.12.3 to 0.12.4 in /bridges/fuzz/storage-proof (#5648) pvf: unignore `terminates_on_timeout` test (#5722) Bump proc-macro2 from 1.0.39 to 1.0.40 (#5719) pass $COMPANION_OVERRIDES to check_dependent_project (#5708) Bump thread_local from 1.1.0 to 1.1.4 in /bridges/fuzz/storage-proof (#5687) Bump quote from 1.0.18 to 1.0.19 (#5700) Rococo: add new pallet-beefy-mmr API (companion for substrate#11406) (#5516) Update metric before bailing out (#5706) Add publish docker staking-miner (#5710)
Contributor
|
Hi @sandreim, do you know if the update made it to the v0.9.25 release? The metric still seems to stay on 1 in this release. |
|
@stakeworld it did not make it into 0.9.25, but will be included in 0.9.26 |
Contributor
|
Thanks for the quick update! |
al3mart
pushed a commit
that referenced
this pull request
Jul 14, 2022
* Update authority metrics before bailing out Signed-off-by: Andrei Sandu <[email protected]> * remove redundant call Signed-off-by: Andrei Sandu <[email protected]> * doc Signed-off-by: Andrei Sandu <[email protected]> * review feedback Signed-off-by: Andrei Sandu <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5664.
The initial implementation (introduced in 0.9.16) was not handling errors correctly - effectively bailing out when we're no longer a validator - see here. This used to work fine until 8bb84d2 because it was always done against
determine_relevant_authoritiesoutput which includes the validators from past sessions, while the secondary check inside the update code would check against current session (the new session). The mentioned change introduces topology changes that make the initial check to be performed on the current session authorities only, resulting in not updating the metrics to 0 when a validator is removed from the active set.