This repository was archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix(staking miner): query latest state when comparing to already submitted solutions #5744
Merged
paritytech-processbot
merged 2 commits into
master
from
na-staking-miner-delay-solution-use-latest-head
Jul 1, 2022
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -138,6 +138,21 @@ async fn ensure_no_better_solution<T: EPM::Config, B: BlockT>( | |
| } | ||
| } | ||
|
|
||
| async fn get_latest_head<T: EPM::Config>( | ||
| rpc: &SharedRpcClient, | ||
| mode: &str, | ||
| ) -> Result<Hash, Error<T>> { | ||
| if mode == "head" { | ||
| match rpc.block_hash(None).await { | ||
| Ok(Some(hash)) => Ok(hash), | ||
| Ok(None) => Err(Error::Other("Best head not found".into())), | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is silly, should be very very unlikely not to get the best block hash ^^ |
||
| Err(e) => Err(e.into()), | ||
| } | ||
| } else { | ||
| rpc.finalized_head().await.map_err(Into::into) | ||
| } | ||
| } | ||
|
|
||
| macro_rules! monitor_cmd_for { ($runtime:tt) => { paste::paste! { | ||
|
|
||
| /// The monitor command. | ||
|
|
@@ -291,13 +306,21 @@ macro_rules! monitor_cmd_for { ($runtime:tt) => { paste::paste! { | |
| let rpc1 = rpc.clone(); | ||
| let rpc2 = rpc.clone(); | ||
|
|
||
| let latest_head = match get_latest_head::<Runtime>(&rpc, &config.listen).await { | ||
| Ok(hash) => hash, | ||
| Err(e) => { | ||
| log::debug!(target: LOG_TARGET, "Skipping to submit at block {}; {}", at.number, e); | ||
| return; | ||
| } | ||
| }; | ||
|
|
||
| let ensure_no_better_fut = tokio::spawn(async move { | ||
| ensure_no_better_solution::<Runtime, Block>(&rpc1, hash, score, config.submission_strategy, | ||
| ensure_no_better_solution::<Runtime, Block>(&rpc1, latest_head, score, config.submission_strategy, | ||
| SignedMaxSubmissions::get()).await | ||
| }); | ||
|
|
||
| let ensure_signed_phase_fut = tokio::spawn(async move { | ||
| ensure_signed_phase::<Runtime, Block>(&rpc2, hash).await | ||
| ensure_signed_phase::<Runtime, Block>(&rpc2, latest_head).await | ||
| }); | ||
|
|
||
| // Run the calls in parallel and return once all has completed or any failed. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be enum? we can probably reuse the same enum in the CLI flags as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha, funny thing I just did that in the other miner repo :P