Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@Szegoo
Copy link
Contributor

@Szegoo Szegoo commented Jul 16, 2022

@paritytech-ci paritytech-ci requested review from a team July 17, 2022 15:39
@Szegoo
Copy link
Contributor Author

Szegoo commented Jul 18, 2022

@kianenigma Do the changes in this pr look correct to you?

Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI you are not adding the new RPC extension here either.

@paritytech-ci paritytech-ci requested a review from a team July 22, 2022 20:45
@Szegoo Szegoo force-pushed the rpc-pending-rewards branch from e05838b to c38be6c Compare July 26, 2022 10:15
@kianenigma kianenigma added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. labels Jul 26, 2022
@kianenigma
Copy link
Contributor

@Szegoo needs update master again. You can give me permission to your branch to finish this.

@Szegoo
Copy link
Contributor Author

Szegoo commented Jul 26, 2022

@Szegoo needs update master again. You can give me permission to your branch to finish this.

I have given you access.

@Szegoo Szegoo force-pushed the rpc-pending-rewards branch from 6fa5447 to c38be6c Compare July 26, 2022 14:29
@Szegoo
Copy link
Contributor Author

Szegoo commented Jul 26, 2022

@kianenigma All the checks are passing, we should be able to merge now :)

@kianenigma
Copy link
Contributor

One last merge of master needed :)

@kianenigma
Copy link
Contributor

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 4a812f5 into paritytech:master Jul 27, 2022
ordian pushed a commit that referenced this pull request Jul 28, 2022
* master: (37 commits)
  Backport crate version bumps to 0.9.27 (#5826)
  Fix GHA (#5825)
  [ci] Add timeout to benchmark jobs (#5822)
  Parachains db column "migration" (#5797)
  Companion for #11831 (#5784)
  [ci] Return production image (#5818)
  add migration for staking v10 (#5817)
  Prepare for rust 1.62.1 (#5811)
  Bump strum to 0.24.1 (#5816)
  Bump substrate (#5814)
  Add missing trigger wildcards for some CI workflows (#5812)
  malus: add `finality_delay` cli flag (#5770)
  [ci] publish parachain-implementers-guide (#5806)
  westend xcm: collectives parachain is trusted teleporter (#5798)
  Cleanup light client leftovers (#5794)
  Fix benchmarking tests (#5791)
  allow re-use and avoid compiling kusama parachain code (#5792)
  Introduce async runtime calling trait for runtime-api subsystem (#5782)
  add `Extrinsic Ordering` check that runs against a local reference node (#5790)
  Co #11456: Expose `benchmark extrinsic` command (#5620)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants