Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

pvf-checker: enable subsystem on all chains #5977

Merged
eskimor merged 2 commits into from
Sep 8, 2022
Merged

pvf-checker: enable subsystem on all chains #5977

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fde2d44
Enable pvf checker on all chains
slumber Sep 7, 2022
721b290
Disable pvf checker for non-authorities
slumber Sep 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Disable pvf checker for non-authorities
  • Loading branch information
@slumber
slumber committed Sep 7, 2022
commit 721b2903ccb72eadd4a0a05647f2922f26806f04
2 changes: 1 addition & 1 deletion node/service/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -801,7 +801,7 @@ where
let auth_or_collator = role.is_authority() || is_collator.is_collator();
let requires_overseer_for_chain_sel = local_keystore.is_some() && auth_or_collator;

let pvf_checker_enabled = !is_collator.is_collator();
let pvf_checker_enabled = role.is_authority() && !is_collator.is_collator();
Copy link
Contributor Author

@slumber slumber Sep 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to submit votes a node is required to be an active validator, enabling it otherwise will unnecessarily poll runtime at each activation.


let select_chain = if requires_overseer_for_chain_sel {
let metrics =
Expand Down