Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Rate limit improvements #6315

Merged
eskimor merged 5 commits into from
Nov 23, 2022
Merged

Rate limit improvements #6315

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a85c9f7
We actually don't need to rate limit redundant requests.
Nov 19, 2022
5c439ed
Add some logging.
Nov 19, 2022
99505d8
Also log message when the receiving side hit the rate limit.
Nov 21, 2022
4ecc6fd
Update node/network/dispute-distribution/src/sender/mod.rs
eskimor Nov 23, 2022
2baca69
Merge branch 'master' into rk-fix-rate-limit
Nov 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
We actually don't need to rate limit redundant requests. 
Those redundant requests should not actually happen, but still.
  • Loading branch information
eskimor committed Nov 19, 2022
commit a85c9f749494366f2a1f95389bb61ea84f0bf0cd
4 changes: 2 additions & 2 deletions node/network/dispute-distribution/src/sender/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,6 @@ impl DisputeSender {
runtime: &mut RuntimeInfo,
msg: DisputeMessage,
) -> Result<()> {
self.rate_limit.limit().await;

let req: DisputeRequest = msg.into();
let candidate_hash = req.0.candidate_receipt.hash();
match self.disputes.entry(candidate_hash) {
Expand All @@ -118,6 +116,8 @@ impl DisputeSender {
return Ok(())
},
Entry::Vacant(vacant) => {
self.rate_limit.limit().await;

let send_task = SendTask::new(
ctx,
runtime,
Expand Down