Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Clippyfy #6341

Merged
10 commits merged into from
Nov 30, 2022
Merged

Clippyfy #6341

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a57a196
Add clippy config and remove .cargo from gitignore
Nov 23, 2022
00c05ec
first fixes
Nov 23, 2022
c4d80f0
Clippyfied
Nov 24, 2022
5fc79c9
Merge branch 'master' into alex/clippyfy
Nov 24, 2022
81fd2a8
Add clippy CI job
Nov 24, 2022
d96fd47
comment out rusty-cachier
Nov 24, 2022
c513688
minor
Nov 24, 2022
e09df27
fix ci
alvicsam Nov 25, 2022
0b70674
remove DAG from check-dependent-project
alvicsam Nov 25, 2022
c27890a
add DAG to clippy
alvicsam Nov 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix ci
  • Loading branch information
@alvicsam
alvicsam committed Nov 25, 2022
commit e09df27a4c86dc13f19dfc97ca8edbe8d03d3d7c
2 changes: 0 additions & 2 deletions scripts/ci/gitlab/pipeline/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,6 @@ build-rustdoc:
needs:
- job: test-deterministic-wasm
artifacts: false
- job: cargo-clippy
artifacts: false
extends:
- .docker-env
- .test-refs
Expand Down
18 changes: 0 additions & 18 deletions scripts/ci/gitlab/pipeline/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,30 +77,12 @@ test-deterministic-wasm:
script:
- ./scripts/ci/gitlab/test_deterministic_wasm.sh

cargo-fmt:
stage: test
variables:
RUSTY_CACHIER_TOOLCHAIN: nightly
extends:
- .docker-env
- .test-refs
script:
# - rusty-cachier snapshot create
- cargo +nightly fmt --all -- --check
# - rusty-cachier cache upload

cargo-clippy:
stage: test
# this is an artificial job dependency, for pipeline optimization using GitLab's DAGs
needs:
- job: cargo-fmt
artifacts: false
variables:
RUSTY_CACHIER_TOOLCHAIN: nightly
extends:
- .docker-env
- .test-refs
script:
# - rusty-cachier snapshot create
- SKIP_WASM_BUILD=1 env -u RUSTFLAGS cargo +nightly clippy --all-targets
Copy link
Member

@bkchr bkchr Nov 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why unsetting RUSTFLAGS? rusty-cachier could be useful here.

Copy link
Author

@ghost ghost Nov 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just copied what substrate does https://github.com/paritytech/substrate/blob/master/scripts/ci/gitlab/pipeline/test.yml#L51

Copy link
Author

@ghost ghost Nov 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do we get rusty-cachier from? I didn't see anything in the substrate repo. Google didn't help either.

Copy link
Member

@bkchr bkchr Nov 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a project from @rcny

Copy link
Contributor

@alvicsam alvicsam Nov 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are going to add rusty-cachier to cumulus and polkadot but now it won't work if you enable it here. So the commented lines can be removed.

Copy link
Contributor

@rcny rcny Nov 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. Current references could be removed as we'll instrument the project with rusty-cachier by ourselves later.

Where do we get rusty-cachier from?

From here. You can read more about the project here.

# - rusty-cachier cache upload