add new job for detecting new bootnodes

.github/workflows/check-new-bootnodes.yml

@@ -0,0 +1,25 @@
+# If a chainspec file is updated with new bootnodes, we check to make sure those bootnodes are contactable
+
+name: Check new bootnodes
+on:
+  pull_request:
+    paths:
+      - 'node/service/chain-specs/*.json'
+
+jobs:
+  check_bootnodes:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout sources
+        uses: actions/checkout@v3
+      - name: Install polkadot
+        shell: bash
+        run: |
+          curl -L "$(curl -s https://api.github.com/repos/paritytech/polkadot/releases/latest \
+          | jq -r '.assets | .[] | select(.name == "polkadot").browser_download_url')" \
+          | sudo tee /usr/local/bin/polkadot > /dev/null
+          sudo chmod +x /usr/local/bin/polkadot
+          polkadot --version
+      - name: Check new bootnodes
+        shell: bash
+        run: scripts/ci/github/check_new_bootnodes.sh

scripts/ci/github/check_bootnodes.sh

@@ -7,22 +7,20 @@
 # been able to contact any other nodes, we can reason that the bootnode we used is not well-connected
 # or is otherwise uncontactable.
 
-# Root of the polkadot dir
-ROOT="$(dirname "${0}")/../../.."
 # shellcheck source=scripts/ci/common/lib.sh
-source "$ROOT/scripts/ci/common/lib.sh"
-RUNTIME="$1"
+source "$(dirname "${0}")/../common/lib.sh"
+CHAINSPEC_FILE="$1"
+RUNTIME=$(basename "$CHAINSPEC_FILE" | cut -d '.' -f 1)
 
 trap cleanup EXIT INT TERM
 
 cleanup(){
     echo "[+] Script interrupted or ended. Cleaning up..."
     # Kill all the polkadot processes
     killall polkadot > /dev/null 2>&1
+    exit $1
 }
 
-# For each runtime
-CHAINSPEC_FILE="$ROOT/node/service/chain-specs/$RUNTIME.json"
 # count the number of bootnodes
 BOOTNODES=$( jq -r '.bootNodes | length' "$CHAINSPEC_FILE" )
 # Make a temporary dir for chainspec files
@@ -66,10 +64,8 @@ if [ ${#BAD_BOOTNODES[@]} -gt 0 ]; then
     for i in "${BAD_BOOTNODES[@]}"; do
         echo "    $i"
     done
-    cleanup
-    exit 1
+    cleanup 1
 else
     echo "[+] All bootnodes for $RUNTIME are contactable"
-    cleanup
-    exit 0
+    cleanup 0
 fi

scripts/ci/github/check_new_bootnodes.sh

@@ -0,0 +1,41 @@
+#!/bin/bash
+ROOT="$(dirname "${0}")/../../.."
+source "$ROOT/scripts/ci/common/lib.sh"
+
+# This script checks any new bootnodes added since the last git commit
+
+RUNTIMES=( kusama westend polkadot )
+
+WAS_ERROR=0
+
+for RUNTIME in "${RUNTIMES[@]}"; do
+    CHAINSPEC_FILE="$ROOT/node/service/chain-specs/$RUNTIME.json"
+    # Get the bootnodes from master's chainspec
+    git show origin/master:"$CHAINSPEC_FILE" | jq '{"oldNodes": .bootNodes}' > "$RUNTIME-old-bootnodes.json"
+    # Get the bootnodes from the current branch's chainspec
+    git show HEAD:"$CHAINSPEC_FILE" | jq '{"newNodes": .bootNodes}' > "$RUNTIME-new-bootnodes.json"
+    # Make a chainspec containing only the new bootnodes
+    jq ".bootNodes = $(jq -rs '.[0] * .[1] | .newNodes-.oldNodes' \
+        "$RUNTIME-new-bootnodes.json" "$RUNTIME-old-bootnodes.json")" \
+        < "$ROOT/node/service/chain-specs/$RUNTIME.json" \
+        > "$RUNTIME-new-chainspec.json"
+    # exit early if the new chainspec has no bootnodes
+    if [ "$(jq -r '.bootNodes | length' "$RUNTIME-new-chainspec.json")" -eq 0 ]; then
+        echo "[+] No new bootnodes for $RUNTIME"
+        # Clean up the temporary files
+        rm "$RUNTIME-new-chainspec.json" "$RUNTIME-old-bootnodes.json" "$RUNTIME-new-bootnodes.json"
+        continue
+    fi
+    # Check the new bootnodes
+    if ! "$ROOT/scripts/ci/github/check_bootnodes.sh" "$RUNTIME-new-chainspec.json"; then
+        WAS_ERROR=1
+    fi
+    # Clean up the temporary files
+    rm "$RUNTIME-new-chainspec.json" "$RUNTIME-old-bootnodes.json" "$RUNTIME-new-bootnodes.json"
+done
+
+
+if [ $WAS_ERROR -eq 1 ]; then
+    echo "[!] One of the new bootnodes failed to connect. Please check logs above."
+    exit 1
+fi