Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

limit number of transactions when building blocks #91

Merged
gavofyork merged 2 commits into from
Jan 18, 2019
Merged

limit number of transactions when building blocks #91

gavofyork merged 2 commits into from
Jan 18, 2019

Conversation

@rphmeier
Copy link
Contributor

@rphmeier rphmeier commented Jan 18, 2019

No description provided.

@rphmeier rphmeier added the A0-please_review Pull request needs code review. label Jan 18, 2019
andresilva
andresilva approved these changes Jan 18, 2019
View reviewed changes
Copy link
Contributor

@andresilva andresilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably do the same thing for basic_authorship in substrate.

andresilva
andresilva reviewed Jan 18, 2019
View reviewed changes
Cargo.lock
[[package]]
name = "polkadot"
version = "0.3.1"
version = "0.3.0"
Copy link
Contributor

@andresilva andresilva Jan 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we bump master out of 0.3?

Copy link
Contributor Author

@rphmeier rphmeier Jan 18, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, i think that's a good call, but i don't want to do this in this PR, because it's going to be backported.

tomusdrw
tomusdrw reviewed Jan 18, 2019
View reviewed changes
consensus/src/lib.rs
use client::block_builder::BlockBuilder;
use runtime_primitives::traits::{Hash as HashT, BlakeTwo256};

const MAX_TRANSACTIONS: usize = 40;
Copy link
Contributor

@tomusdrw tomusdrw Jan 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already MAX_TRANSACTIONS_SIZE constant, maybe move the two close to each other (rather move the other one here).

Copy link
Contributor Author

@rphmeier rphmeier Jan 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately it's not possible to move the MAX_TRANSACTIONS_SIZE down for now because it's used elsewhere.

@gavofyork gavofyork merged commit 3ae3200 into master Jan 18, 2019
@gavofyork gavofyork deleted the rh-txlimit branch January 18, 2019 15:31
gavofyork pushed a commit that referenced this pull request Jan 18, 2019
@rphmeier @gavofyork
limit number of transactions when building blocks (#91)
a35186d
rphmeier pushed a commit that referenced this pull request Mar 28, 2019
@bkchr @rphmeier
Update to latest substrate-master and polkadot v0.3 (#195)
adba1d5 
* Rebuild runtime

* Remove invalid value from chainspec (#68)

* service: use grandpa block import for locally sealed aura blocks (#85)

* bump version to v0.3.1

* Update lock file.

* limit number of transactions when building blocks (#91)

* Update to latest Substrate

* Bump to 0.3.2

* Actually bump.

* v0.3.2 (#98)

* bump substrate version

* fix polkadot-collator

* point to alexander-backports of substrate

* bump version

* cli: fix node shutdown (#100)

* update to latest substrate, change to v0.3.4

* update to latest substrate, bump version to 0.3.5

* v0.3.6

* try to build on every v0.3 commit and update alexander-backports

* bump to v0.3.7

* bump to 0.3.8

* Bump to 0.3.9: network and pruning improvements

* Bump to 0.3.10: reduce network bandwidth usage

* Use libp2p-kad 0.3.2 (#122)

* Bump libp2p-identify to 0.3.1 (#123)

* Bump to 0.3.12 (#127)

* Update Substrate again (#128)

* update substrate and bump version to v0.3.13

* bump version to v0.3.14: fix --reserved-nodes

* add a manually curated grandpa module (#136)

* updating v0.3 to use substrate v0.10 (#146)

* updating to latest substrate v0.10

* better handling of outer poll

* nit

* fix tests

* remove comment

* reduce indentation

* use self.poll

* bring oneshot into scope

* spaces

* wrap

* remove match

* wrap

* Update primitives/Cargo.toml

Co-Authored-By: gterzian <[email protected]>

* Update runtime/wasm/Cargo.toml

Co-Authored-By: gterzian <[email protected]>

* Update runtime/wasm/Cargo.toml

Co-Authored-By: gterzian <[email protected]>

* Update test-parachains/adder/collator/src/main.rs

Co-Authored-By: gterzian <[email protected]>

* indent

* add paranthese

* config: fix wrong ip for alexander bootnode (#161)

* fix curated-grandpa and rebuild wasm (#162)

* [v0.3] Integrates new gossip system into Polkadot (#166)

* new gossip validation in network

* integrate new gossip into service

* network: guard validation network future under exit signal (#168)

* bump version to v0.3.15: substrate v0.10

* [v0.3] update to substrate master (#175)

* update to substrate master

* fix test

* service: fix telemetry endpoints on alexander chainspec (#169) (#178)

* Update v0.3 to latest Substrate master (#177)

* update substrate v0.3 to latest master

* bump spec version

* update to latest master: remove fees module

* update runtime blobs

* bump version to 0.3.16

* replace sr25519 accountid with anysigner

* bump version to v0.3.17

* Some PoC-3 GRANDPA tweaks (#181)

* call on_finalise after triggering curated_grandpa change

* make grandpa rounds shorter for faster finalization

* use authorities when calculating duty roster (#185)

* [v0.3] Update to substrate master (#183)

* update to latest substrate master

* bump version to 0.3.18

* update to latest substrate master

* bump spec version

* update runtime wasm blobs

* remove current_offline_slash from chain spec

* update to substrate master: bump version to v0.3.19 (#188)

* update to substrate master: bump version to v0.3.19

libp2p network improvements

* network: replace NodeIndex with PeerId

* network: fix tests

* polkadot v0.3.20 (#190)

* update to substrate master: bump version to 0.3.20

* runtime: add offchain worker trait

* runtime: rebuild wasm blobs

* bump spec version (#191)

* Fix compilation

* Update version to 0.4.0

* Switch to use `polkadot-master` branch from substrate

* Remove unused struct

* Remove `grandpa::SyncedAuthorities` from `OnSessionChange`
tomusdrw added a commit that referenced this pull request Mar 26, 2021
@svyatonik @tomusdrw @HCastano
Claim funds on Substrate chain by providing proof of funds locking on…
76ba7fd 
… PoA chain (#91)

* ethereum exchange module

* continue

* continue

* added tests for exchange module

* moved

* remove println

* move again

* fixes

* removed redundant deps

* cargo fmt

* fund_locks_transaction_decode_works

* cargo fmt --all

* fix error processing

* added some tracing to bridge modules

* more tests

* more tests

* cargo fmt --all

* kovan.rs -> exchange.rs

* Update bin/node/runtime/src/exchange.rs

Co-authored-by: Tomasz Drwięga <[email protected]>

* added assumption doc

* Airdrop -> DepositInto

* AsIs -> Identity

* OnTransactionSubmitted

* Transfers::Key = Id

* typo

* Update bin/node/runtime/src/exchange.rs

Co-authored-by: Tomasz Drwięga <[email protected]>

* block+tx+proof -> proof { block, tx, proof }

* cargo fmt --all

* docs

* check <-> verify

* parse hex

* extracted exchange primitives to separate crate

* added docs to runtime::exchange module

* Update bin/node/runtime/src/exchange.rs

Co-authored-by: Hernando Castano <[email protected]>

* typo

* Update modules/currency-exchange/Cargo.toml

Co-authored-by: Hernando Castano <[email protected]>

* add docs to currency-exchange module

* change tests names

* cargo fmt --all

* Update bin/node/runtime/src/exchange.rs

Co-authored-by: Hernando Castano <[email protected]>

* Update bin/node/runtime/src/exchange.rs

Co-authored-by: Hernando Castano <[email protected]>

* Update bin/node/runtime/src/exchange.rs

Co-authored-by: Hernando Castano <[email protected]>

* Update bin/node/runtime/src/exchange.rs

Co-authored-by: Hernando Castano <[email protected]>

* Update bin/node/runtime/src/exchange.rs

Co-authored-by: Hernando Castano <[email protected]>

* fixed verify_transaction_finalized for siblings of finalized blocks

* cargo fmt --all

* added double spend note

* cargo fmt --all

Co-authored-by: Tomasz Drwięga <[email protected]>
Co-authored-by: Hernando Castano <[email protected]>
imstar15 pushed a commit to imstar15/polkadot that referenced this pull request Aug 25, 2021
@cecton
Integration test (paritytech#91)
0a7cde6
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@andresilva andresilva andresilva approved these changes

@tomusdrw tomusdrw tomusdrw left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rphmeier @andresilva @tomusdrw @gavofyork