This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Companion to child trie api change #4857 #950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like @cheme signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
gavofyork
added
A0-please_review
gnunicorn
approved these changes
Apr 20, 2020
Contributor
gnunicorn
left a comment
gnunicorn
left a comment
There was a problem hiding this comment.
superficial overview looks decent.
Contributor
|
@cheme could you push a |
Contributor
Author
|
@gnunicorn I also did bump all spec version. |
Contributor
Author
|
Seems good to merge, I am just not 100% sure if bump in version was needed for every runtime? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a companion PR for the child trie api made in paritytech/substrate#4857 .