Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Use tempdir for tests #993

Merged
bkchr merged 7 commits into from
Apr 13, 2020
Merged

Use tempdir for tests #993

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
43e48e1
Use tempdir for tests
Apr 13, 2020
04a994f
Rename tmp to tempdir
Apr 13, 2020
a55ea1c
Update Cargo.lock
Apr 13, 2020
4b39837
Update expect error message in run_command_and_kill
Apr 13, 2020
df62559
Call with .path() rather than creating an string slice
Apr 13, 2020
51d1cd4
Call tempdir with arg instead of args
Apr 13, 2020
facd714
Update tests/purge_chain_works.rs
bkchr Apr 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename tmp to tempdir
  • Loading branch information
Scott Piriou committed Apr 13, 2020
commit 04a994f5cd947c258eafa56ee95d0447aa498784
4 changes: 2 additions & 2 deletions tests/invalid_order_arguments.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ use tempfile::tempdir;
#[test]
#[cfg(unix)]
fn invalid_order_arguments() {
let tmp = tempdir().expect("could not create temp dir");
let base_path = tmp.path().to_str().expect("path should consist of valid utf8 characters");
let tmpdir = tempdir().expect("could not create temp dir");
let base_path = tmpdir.path().to_str().expect("path should consist of valid utf8 characters");

let status = Command::new(cargo_bin("polkadot"))
.args(&["--dev", "invalid_order_arguments", "-d", base_path, "-y"])
Expand Down
4 changes: 2 additions & 2 deletions tests/running_the_node_and_interrupt.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ fn running_the_node_works_and_can_be_interrupted() {
use nix::unistd::Pid;

fn run_command_and_kill(signal: Signal) {
let tmp = tempdir().expect("coult not create temp dir");
let base_path = tmp.path().to_str().expect("path should be valid utf8");
let tmpdir = tempdir().expect("coult not create temp dir");
let base_path = tmpdir.path().to_str().expect("path should be valid utf8");

let mut cmd = Command::new(cargo_bin("polkadot"))
.args(&["--dev", "-d", base_path])
Expand Down