Skip to content

Fix PhantomData filtering #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ascjones merged 6 commits into from
Jul 19, 2021
Merged

Fix PhantomData filtering #115

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7083c10
Filter out Phantom fields from tuple structs
ascjones Jul 16, 2021
05f0a25
Don't panic
ascjones Jul 16, 2021
32bcf41
Fmt
ascjones Jul 16, 2021
adaca9c
Remove should_panic test
ascjones Jul 16, 2021
754eebd
Fix phantom filter tests
ascjones Jul 16, 2021
29e6a58
Fmt
ascjones Jul 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fmt
  • Loading branch information
@ascjones
ascjones committed Jul 16, 2021
commit 29e6a58e95374f0f85f87cf2aba79c131a96dd2c
10 changes: 2 additions & 8 deletions test_suite/tests/derive.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,7 @@ fn phantom_data_field_is_erased() {
let ty = Type::builder()
.path(Path::new("P", "derive"))
.type_params(named_type_params!((T, bool)))
.composite(
Fields::named()
.field(|f| f.ty::<u8>().name("a").type_name("u8"))
);
.composite(Fields::named().field(|f| f.ty::<u8>().name("a").type_name("u8")));

assert_type!(P<bool>, ty);
}
Expand All @@ -125,10 +122,7 @@ fn phantom_data_tuple_struct_field_is_erased() {
let ty = Type::builder()
.path(Path::new("P", "derive"))
.type_params(named_type_params!((T, bool)))
.composite(
Fields::unnamed()
.field(|f| f.ty::<u8>().type_name("u8"))
);
.composite(Fields::unnamed().field(|f| f.ty::<u8>().type_name("u8")));

assert_type!(P<bool>, ty);
}
Expand Down