Add public getters for fields in meta type hierarchy #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robbepop
reviewed
Sep 9, 2020
Contributor
Robbepop
left a comment
Robbepop
left a comment
There was a problem hiding this comment.
Is this not possible with some idiomatic getters instead?
Contributor
Author
|
I thought it was idiomatic for these types which are data, e.g. in |
ascjones
changed the title
ascjones
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #19 which enables decoding of
scale-infometa types, this PR makes the fields of those types accessible via public getters.The motivation for this is to allow 3rd party libraries to make use of instances of the meta types for e.g code generation of types in another language.
The immediate use case I am planning for is to build a library which is able to deserialize
ink!contract metadata and use that to construct contract calls.Additionally we rename
Form::TypeIdtoForm::Typeto be more accurate.