Add a new TypeDef variant to handle PhantomData #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvdplm
commented
Jan 7, 2021
Robbepop
reviewed
Jan 8, 2021
ascjones
suggested changes
Jan 12, 2021
Contributor
ascjones
left a comment
ascjones
left a comment
There was a problem hiding this comment.
Just need to fix the identity of PhantomData<T>, some tests may fail
Robbepop
reviewed
Jan 18, 2021
Contributor
Robbepop
left a comment
Robbepop
left a comment
There was a problem hiding this comment.
All in all code looks good.
The only thing I am missing is an in-depth comment explaining the design rationals behind this PR so that we won't forget why we chose this design instead of others we previously talked about. I always love finding such comments when I forgot about certain rationals after months of not looking at the issue.
Make From impl consistent with other types of types
Contributor
Author
Closed
Contributor
|
I'd love to have the example of reconstructing rust types given the scale info metadata as motivation for having PhantomData deginitions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #31 (comment) for the background.
Supersedes #31
Closes #7
Note that we do not yet have support for
#[codec(skip)](implemented in PR #44) so when that lands we'll want to amend the tests here (or there, if this lands first).