Skip to content

Robust crate names (alternative to #61) #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dvdplm wants to merge 11 commits into from
Closed

Robust crate names (alternative to #61) #62

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4a67533
Add crate imports with known names
ascjones Feb 2, 2021
531dd5d
Use known crate name aliases
ascjones Feb 2, 2021
459e29b
Remove hack for tests, it doesn't apply to all crates
ascjones Feb 2, 2021
63f8f49
Use alias ident
ascjones Feb 2, 2021
159f626
Fix parity_scale_codec crate alias, remove unused imports and args
ascjones Feb 2, 2021
c3cadc6
Fmt
ascjones Feb 2, 2021
38ef7df
Add PR to "Unreleased" section
ascjones Feb 2, 2021
9ab7c51
Update rustfmt config
ascjones Feb 2, 2021
b292cc9
review: use absolute paths with crate names
ascjones Feb 2, 2021
585b757
Use static crate names
dvdplm Feb 2, 2021
a7be4b8
fmt
dvdplm Feb 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fmt
  • Loading branch information
@ascjones
ascjones committed Feb 2, 2021
commit c3cadc6994b297b703e7586430f97920afcf5279
6 changes: 2 additions & 4 deletions derive/src/impl_wrapper.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,7 @@ use proc_macro2::{
use quote::quote;
use syn::Ident;

pub fn wrap(
impl_quote: TokenStream2,
) -> TokenStream2 {
pub fn wrap(impl_quote: TokenStream2) -> TokenStream2 {
let include_scale_info = include_crate("scale-info", "_scale_info");
let include_parity_scale_codec = include_crate("parity-scale-codec", "_scale");

Expand All @@ -43,7 +41,7 @@ fn include_crate(name: &str, alias: &str) -> proc_macro2::TokenStream {
let crate_name_ident = Ident::new(&crate_name, Span::call_site());
let crate_alias_ident = Ident::new(&alias, Span::call_site());
quote!( extern crate #crate_name_ident as #crate_alias_ident; )
},
}
Err(e) => syn::Error::new(Span::call_site(), &e).to_compile_error(),
}
}