fix: install WASM target for non-default RUSTC versions #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntn-x2
force-pushed
the
aa/wasm-target-install
branch
from
4a9b64f to
db14630
Compare
ntn-x2
force-pushed
the
aa/wasm-target-install
branch
from
db14630 to
7d35603
Compare
|
Cc @chevdor and @EgorPopelyaev |
alvicsam
added a commit
that referenced
this pull request
Feb 24, 2025
EgorPopelyaev
added a commit
that referenced
this pull request
Feb 25, 2025
* Update uploadt-artifact to v4 * update action/cache * test * bumping rustc_version to 1.84 * add wasm32v1-none * keep 1.81 for fellowship * add wasm32-unknown-unknown to srtool run * try suggestion from #90 * Bump srtool version --------- Co-authored-by: alvicsam <[email protected]> Co-authored-by: EgorPopelyaev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I try to specify a different
RUSTCversion than the one the container was built with, I guess an error when compiling the runtime:Cannot compile the WASM runtime: thewasm32-unknown-unknowntarget is not installed!. The link to the failing Gitlab pipeline is here: https://gitlab.com/kiltprotocol/kilt-node/-/jobs/8516236006.If I try to add the relevant
rustupinstruction myself in the image setup step, I get the error/usr/bin/bash: line 166: rustup: command not found. A link to the failing pipeline is here: https://gitlab.com/kiltprotocol/kilt-node/-/jobs/8516444684.Hence I believe the fix is to add the
wasm32-unknown-unknowntarget by default after overriding the rustc info.