Skip to content

config: Enhance CUSTOM_TYPES to take Object too. #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emostov merged 2 commits into from
Dec 4, 2020
Merged

config: Enhance CUSTOM_TYPES to take Object too. #357

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09585fb
config: Enhance CUSTOM_TYPES to take AnyJson
amarts Dec 1, 2020
b364d43
Use RegistryTypes
emostov Dec 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
config: Enhance CUSTOM_TYPES to take AnyJson 
If a pallet is updating a block with type Json, the Record<string, string>
is not going to meet the needs.
Enhancing the type of the CUSTOM_TYPES to take json object with
`AnyJson` type would fix the issues.

Signed-off-by: Amar Tumballi <[email protected]>
  • Loading branch information
@amarts
amarts committed Dec 2, 2020
commit 09585fba8caa0c2f91ad2bbc56adec6d4c53208e
4 changes: 3 additions & 1 deletion src/types/config/SidecarConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import { AnyJson } from '@polkadot/types/types';

/**
* Object to house the values of all the configurable components for Sidecar.
*/
Expand All @@ -9,7 +11,7 @@ export interface ISidecarConfig {

interface ISidecarConfigSubstrate {
WS_URL: string;
CUSTOM_TYPES: Record<string, string> | undefined;
CUSTOM_TYPES: AnyJson;
}

interface ISidecarConfigExpress {
Expand Down