Skip to content

[WIP] State Tracing #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
insipx wants to merge 15 commits into from
Closed

[WIP] State Tracing #92

Changes from 2 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
8496ea5
re-add state tracing PR
Sep 2, 2020
563066a
add more sensible defaults in config
Sep 3, 2020
ddb69c2
use crates dep for coil
Sep 3, 2020
56ab46e
fix archive hanging on bg task timeout
Sep 10, 2020
0c903a6
remove enqueue logs
insipx Sep 10, 2020
31a564b
Merge branch 'state-tracing' of github.com:paritytech/substrate-archi…
insipx Sep 10, 2020
724125b
uncomment polkadot service
Sep 11, 2020
0be4e32
merged
Sep 11, 2020
1e8cbcc
pin project to 8.23
Sep 16, 2020
80c0e73
merge
Sep 16, 2020
082701b
pin polkadot
Sep 16, 2020
eb04221
use own fork of polkadot
Sep 16, 2020
50cb9e0
debugging native runtimes WIP
insipx Sep 16, 2020
02a20a6
cleanup, cargo clippy
Sep 19, 2020
02ce0ba
Polkadot cargo.lock
Sep 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/actors.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,8 +223,16 @@ where
futures::pin_mut!(tasks);
futures::select! {
t = tasks => {
if t? == 0 {
smol::Timer::new(std::time::Duration::from_millis(3600)).await;
match t {
Err(coil::FetchError::Timeout) => {
log::warn!("Timeout waiting for task to start");
continue;
},
v => {
if v? == 0 {
smol::Timer::new(std::time::Duration::from_millis(3600)).await;
}
}
Comment on lines +226 to +230
Copy link
Contributor

@dvdplm dvdplm Oct 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can do something like

Ok(v) if v == 0 => { … … },
Ok(_) => {} // but maybe we want to log something here?
Err(FailedLoadingJob) => { … … }

Not sure if it's better, but sometimes explicit is good.

}
},
_ = rx.recv_async() => break,
Expand Down