Change the localtest address from localhost to 127.0.0.1

The polkadot node does not listen on the IPv6 localhost by default.
This caused failures on systems that resolve localhost to ::1

src/tip.ts

@@ -5,134 +5,134 @@ import assert from "assert";
 import { Contributor, ContributorAccount, State, TipMetadata, TipNetwork, TipSize } from "./types";
 
 export function getTipSize(tipSizeInput: string | undefined): TipSize {
-  const validTipSizes: { [key: string]: TipSize } = { small: "small", medium: "medium", large: "large" } as const;
+    const validTipSizes: { [key: string]: TipSize } = { small: "small", medium: "medium", large: "large" } as const;
 
-  if (!tipSizeInput || !(tipSizeInput in validTipSizes)) {
-    throw new Error(`Invalid tip size. Please specify one of ${Object.keys(validTipSizes).join(", ")}.`);
-  }
+    if (!tipSizeInput || !(tipSizeInput in validTipSizes)) {
+        throw new Error(`Invalid tip size. Please specify one of ${Object.keys(validTipSizes).join(", ")}.`);
+    }
 
-  return validTipSizes[tipSizeInput];
+    return validTipSizes[tipSizeInput];
 }
 
 export function parseContributorAccount(pullRequestBody: string | null): ContributorAccount {
-  const matches =
-    typeof pullRequestBody === "string" &&
-    pullRequestBody.match(
-      // match "polkadot address: <ADDRESS>"
-      /(\S+)\s*address:\s*([a-z0-9]+)/i,
-    );
-
-  if (matches === false || matches === null || matches.length != 3) {
-    throw new Error(
-      `Contributor did not properly post their account address.\n\nMake sure the pull request description has: "{network} address: {address}".`,
-    );
-  }
-
-  const [matched, networkInput, address] = matches;
-  assert(networkInput, `networkInput could not be parsed from "${matched}"`);
-  assert(address, `address could not be parsed from "${matched}"`);
-
-  const validNetworks: { [key: string]: TipNetwork } = {
-    polkadot: "polkadot",
-    kusama: "kusama",
-    localtest: "localtest",
-  };
-
-  const network =
-    networkInput.toLowerCase() in validNetworks
-      ? validNetworks[networkInput.toLowerCase() as keyof typeof validNetworks]
-      : undefined;
-  if (!network) {
-    throw new Error(
-      `Invalid network: "${networkInput}". Please select one of: ${Object.keys(validNetworks).join(", ")}.`,
-    );
-  }
-
-  return { network, address };
+    const matches =
+        typeof pullRequestBody === "string" &&
+        pullRequestBody.match(
+            // match "polkadot address: <ADDRESS>"
+            /(\S+)\s*address:\s*([a-z0-9]+)/i,
+        );
+
+    if (matches === false || matches === null || matches.length != 3) {
+        throw new Error(
+            `Contributor did not properly post their account address.\n\nMake sure the pull request description has: "{network} address: {address}".`,
+        );
+    }
+
+    const [matched, networkInput, address] = matches;
+    assert(networkInput, `networkInput could not be parsed from "${matched}"`);
+    assert(address, `address could not be parsed from "${matched}"`);
+
+    const validNetworks: { [key: string]: TipNetwork } = {
+        polkadot: "polkadot",
+        kusama: "kusama",
+        localtest: "localtest",
+    };
+
+    const network =
+        networkInput.toLowerCase() in validNetworks
+            ? validNetworks[networkInput.toLowerCase() as keyof typeof validNetworks]
+            : undefined;
+    if (!network) {
+        throw new Error(
+            `Invalid network: "${networkInput}". Please select one of: ${Object.keys(validNetworks).join(", ")}.`,
+        );
+    }
+
+    return { network, address };
 }
 
 /* TODO add some kind of timeout then return an error
    TODO Unit tests */
 export async function tipUser(
-  state: State,
-  {
-    contributor,
-    pullRequestNumber,
-    pullRequestRepo,
-    tipSize,
-  }: {
-    contributor: Contributor;
-    pullRequestNumber: number;
-    pullRequestRepo: string;
-    tipSize: string;
-  },
+    state: State,
+    {
+        contributor,
+        pullRequestNumber,
+        pullRequestRepo,
+        tipSize,
+    }: {
+        contributor: Contributor;
+        pullRequestNumber: number;
+        pullRequestRepo: string;
+        tipSize: string;
+    },
 ): Promise<{ success: boolean; tipUrl: string }> {
-  const { bot } = state;
-  const { provider, botTipAccount, tipUrl } = await getContributorMetadata(state, contributor);
-
-  const api = await ApiPromise.create({ provider });
-
-  // Get general information about the node we are connected to
-  const [chain, nodeName, nodeVersion] = await Promise.all([
-    api.rpc.system.chain(),
-    api.rpc.system.name(),
-    api.rpc.system.version(),
-  ]);
-
-  bot.log(`You are connected to chain ${chain.toString()} using ${nodeName.toString()} v${nodeVersion.toString()}`);
-
-  const reason = `TO: ${contributor.githubUsername} FOR: ${pullRequestRepo}#${pullRequestNumber} (${tipSize})`;
-  /* TODO before submitting, check tip does not already exist via a storage query.
-     TODO potentially prevent duplicates by also checking for reasons with the other sizes. */
-  const unsub = await api.tx.tips
-    .reportAwesome(reason, contributor.account.address)
-    .signAndSend(botTipAccount, (result: SubmittableResult) => {
-      bot.log(`Current status is ${result.status.toString()}`);
-      if (result.status.isInBlock) {
-        bot.log(`Tip included at blockHash ${result.status.asInBlock.toString()}`);
-      } else if (result.status.isFinalized) {
-        bot.log(`Tip finalized at blockHash ${result.status.asFinalized.toString()}`);
-        unsub();
-      }
-    });
-
-  return { success: true, tipUrl };
+    const { bot } = state;
+    const { provider, botTipAccount, tipUrl } = await getContributorMetadata(state, contributor);
+
+    const api = await ApiPromise.create({ provider });
+
+    // Get general information about the node we are connected to
+    const [chain, nodeName, nodeVersion] = await Promise.all([
+        api.rpc.system.chain(),
+        api.rpc.system.name(),
+        api.rpc.system.version(),
+    ]);
+
+    bot.log(`You are connected to chain ${chain.toString()} using ${nodeName.toString()} v${nodeVersion.toString()}`);
+
+    const reason = `TO: ${contributor.githubUsername} FOR: ${pullRequestRepo}#${pullRequestNumber} (${tipSize})`;
+    /* TODO before submitting, check tip does not already exist via a storage query.
+       TODO potentially prevent duplicates by also checking for reasons with the other sizes. */
+    const unsub = await api.tx.tips
+        .reportAwesome(reason, contributor.account.address)
+        .signAndSend(botTipAccount, (result: SubmittableResult) => {
+            bot.log(`Current status is ${result.status.toString()}`);
+            if (result.status.isInBlock) {
+                bot.log(`Tip included at blockHash ${result.status.asInBlock.toString()}`);
+            } else if (result.status.isFinalized) {
+                bot.log(`Tip finalized at blockHash ${result.status.asFinalized.toString()}`);
+                unsub();
+            }
+        });
+
+    return { success: true, tipUrl };
 }
 
 async function getContributorMetadata(state: State, contributor: Contributor): Promise<TipMetadata> {
-  await cryptoWaitReady();
-  const { seedOfTipperAccount } = state;
-  const keyring = new Keyring({ type: "sr25519" });
-  const botTipAccount = keyring.addFromUri(seedOfTipperAccount);
-
-  switch (contributor.account.network) {
-    case "localtest": {
-      return {
-        provider: new WsProvider("ws://localhost:9944"),
-        botTipAccount: keyring.addFromUri("//Alice", { name: "Alice default" }),
-        tipUrl: "https://polkadot.js.org/apps/?rpc=ws%3A%2F%2F127.0.0.1%3A9944#/treasury/tips",
-      };
-    }
-    case "polkadot": {
-      return {
-        provider: new WsProvider("wss://rpc.polkadot.io"),
-        botTipAccount,
-        tipUrl: "https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frpc.polkadot.io#/treasury/tips",
-      };
-    }
-    case "kusama": {
-      return {
-        provider: new WsProvider(`wss://${contributor.account.network}-rpc.polkadot.io`),
-        botTipAccount,
-        tipUrl: `https://polkadot.js.org/apps/?rpc=wss%3A%2F%${contributor.account.network}-rpc.polkadot.io#/treasury/tips`,
-      };
-    }
-    default: {
-      const exhaustivenessCheck: never = contributor.account.network;
-      throw new Error(
-        // eslint-disable-next-line @typescript-eslint/restrict-template-expressions
-        `Network is not handled properly in tipUser: ${exhaustivenessCheck}`,
-      );
+    await cryptoWaitReady();
+    const { seedOfTipperAccount } = state;
+    const keyring = new Keyring({ type: "sr25519" });
+    const botTipAccount = keyring.addFromUri(seedOfTipperAccount);
+
+    switch (contributor.account.network) {
+        case "localtest": {
+            return {
+                provider: new WsProvider("ws://127.0.0.1:9944"),
+                botTipAccount: keyring.addFromUri("//Alice", { name: "Alice default" }),
+                tipUrl: "https://polkadot.js.org/apps/?rpc=ws%3A%2F%2F127.0.0.1%3A9944#/treasury/tips",
+            };
+        }
+        case "polkadot": {
+            return {
+                provider: new WsProvider("wss://rpc.polkadot.io"),
+                botTipAccount,
+                tipUrl: "https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frpc.polkadot.io#/treasury/tips",
+            };
+        }
+        case "kusama": {
+            return {
+                provider: new WsProvider(`wss://${contributor.account.network}-rpc.polkadot.io`),
+                botTipAccount,
+                tipUrl: `https://polkadot.js.org/apps/?rpc=wss%3A%2F%${contributor.account.network}-rpc.polkadot.io#/treasury/tips`,
+            };
+        }
+        default: {
+            const exhaustivenessCheck: never = contributor.account.network;
+            throw new Error(
+                // eslint-disable-next-line @typescript-eslint/restrict-template-expressions
+                `Network is not handled properly in tipUser: ${exhaustivenessCheck}`,
+            );
+        }
     }
-  }
 }