This repository was archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
This repository was archived by the owner on Nov 15, 2023. It is now read-only.
[client/network] Update authority discovery after authority-discovery w/ PR#3230 is released #13338
Copy link
Copy link
Closed
Labels
U3-nice_to_haveIssue is worth doing eventually.Issue is worth doing eventually.
Description
libp2p/rust-libp2p#3230 invalidates the assumptions in Substrate's Authority Discovery.
substrate/client/authority-discovery/src/lib.rs
Lines 88 to 109 in 8d11cec
| impl Default for WorkerConfig { | |
| fn default() -> Self { | |
| Self { | |
| // Kademlia's default time-to-live for Dht records is 36h, republishing records every | |
| // 24h through libp2p-kad. Given that a node could restart at any point in time, one can | |
| // not depend on the republishing process, thus publishing own external addresses should | |
| // happen on an interval < 36h. | |
| max_publish_interval: Duration::from_secs(1 * 60 * 60), | |
| keystore_refresh_interval: Duration::from_secs(60), | |
| // External addresses of remote authorities can change at any given point in time. The | |
| // interval on which to trigger new queries for the current and next authorities is a | |
| // trade off between efficiency and performance. | |
| // | |
| // Querying 700 [`AuthorityId`]s takes ~8m on the Kusama DHT (16th Nov 2020) when | |
| // comparing `authority_discovery_authority_addresses_requested_total` and | |
| // `authority_discovery_dht_event_received`. | |
| max_query_interval: Duration::from_secs(10 * 60), | |
| publish_non_global_ips: true, | |
| strict_record_validation: false, | |
| } | |
| } | |
| } |
"Either you go with the new defaults and update Authority Discovery, or you override the defaults of libp2p."
libp2p/rust-libp2p#3230 (comment)
opening an issue so we don't forget
bkchr
Metadata
Metadata
Assignees
Labels
U3-nice_to_haveIssue is worth doing eventually.Issue is worth doing eventually.
Type
Projects
Status
Done ✅