Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@Doordashcon
Copy link
Contributor

@Doordashcon Doordashcon commented Nov 13, 2021

This pull request changes the pallet Events variants from tuples to structs with named fields.

Part implementation for #9903, #9993, #10184 & #10206

Pallets with changes

  • recovery
  • session

@Doordashcon Doordashcon marked this pull request as draft November 15, 2021 20:55
@Doordashcon Doordashcon marked this pull request as ready for review November 15, 2021 21:43
@gui1117 gui1117 added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Nov 17, 2021
Copy link
Contributor

@gui1117 gui1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from the grumble on the name (fixed), all good to me

@gui1117
Copy link
Contributor

gui1117 commented Nov 20, 2021

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 197b8fd into paritytech:master Nov 20, 2021
@Doordashcon Doordashcon deleted the ddc-AFNPEV-T3 branch November 20, 2021 08:15
grishasobol pushed a commit to gear-tech/substrate that referenced this pull request Mar 28, 2022
* AFNPEV recovery

* AFNPEV session

* cargo +nightly fmt && cargo fmt

* removed redundant comments

* update

* update & cargo +nightly fmt

* update & cargo +nightly fmt

* update recovery/src/lib.rs

* update session/src/lib.rs
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
* AFNPEV recovery

* AFNPEV session

* cargo +nightly fmt && cargo fmt

* removed redundant comments

* update

* update & cargo +nightly fmt

* update & cargo +nightly fmt

* update recovery/src/lib.rs

* update session/src/lib.rs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants