Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
dccce70
Add new hardware and software metrics
koute Mar 18, 2022
99633f9
Move sysinfo tests into `mod tests`
koute Mar 23, 2022
55c7358
Correct a typo in a comment
koute Mar 23, 2022
909df21
Remove unnecessary `nix` dependency
koute Mar 23, 2022
706e4d3
Fix the version tests
koute Mar 23, 2022
c1e409f
Add a `--disable-hardware-benchmarks` CLI argument
koute Mar 24, 2022
a05159a
Disable hardware benchmarks in the integration tests
koute Mar 25, 2022
fff4573
Remove unused import
koute Mar 25, 2022
3d15f0e
Fix benchmarks compilation
koute Mar 25, 2022
a8c71c1
Merge remote-tracking branch 'origin/master' into master_hwswinfo
koute Mar 25, 2022
d215b39
Move code to a new `sc-sysinfo` crate
koute Mar 28, 2022
c1da1fa
Correct `impl_version` comment
koute Mar 28, 2022
b98bcfa
Move `--disable-hardware-benchmarks` to the chain-specific bin crate
koute Mar 28, 2022
0d25408
Move printing out of hardware bench results to `sc-sysinfo`
koute Mar 28, 2022
46c9de2
Move hardware benchmarks to a separate messages; trigger them manually
koute Mar 29, 2022
56a1e3a
Rename some of the fields in the `HwBench` struct
koute Mar 31, 2022
457b4da
Revert changes to the telemetry crate; manually send hwbench messages
koute Apr 4, 2022
bb26cfa
Move sysinfo logs into the sysinfo crate
koute Apr 4, 2022
77f9c5f
Move the `TARGET_OS_*` constants into the sysinfo crate
koute Apr 4, 2022
73b230a
Minor cleanups
koute Apr 5, 2022
c3214e5
Move the `HwBench` struct to the sysinfo crate
koute Apr 5, 2022
b6d78a0
Derive `Clone` for `HwBench`
koute Apr 5, 2022
19f43ab
Fix broken telemetry connection notification stream
koute Apr 5, 2022
15e5f9e
Prevent the telemetry connection notifiers from leaking if they're di…
koute Apr 5, 2022
e5f210f
Turn the telemetry notification failure log into a debug log
koute Apr 6, 2022
0cafbf8
Rename `--disable-hardware-benchmarks` to `--no-hardware-benchmarks`
koute Apr 6, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Disable hardware benchmarks in the integration tests
  • Loading branch information
koute committed Mar 25, 2022
commit a05159a9258e3a6b032e6bf18a469ab03b51718c
3 changes: 2 additions & 1 deletion bin/node/cli/tests/check_block_works.rs
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ pub mod common;
async fn check_block_works() {
let base_path = tempdir().expect("could not create a temp dir");

common::run_node_for_a_while(base_path.path(), &["--dev"]).await;
common::run_node_for_a_while(base_path.path(), &["--dev", "--disable-hardware-benchmarks"])
.await;

let status = Command::new(cargo_bin("substrate"))
.args(&["check-block", "--dev", "--pruning", "archive", "-d"])
Expand Down
3 changes: 2 additions & 1 deletion bin/node/cli/tests/export_import_flow.rs
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,8 @@ async fn export_import_revert() {
let exported_blocks_file = base_path.path().join("exported_blocks");
let db_path = base_path.path().join("db");

common::run_node_for_a_while(base_path.path(), &["--dev"]).await;
common::run_node_for_a_while(base_path.path(), &["--dev", "--disable-hardware-benchmarks"])
.await;

let mut executor = ExportImportRevertExecutor::new(&base_path, &exported_blocks_file, &db_path);

Expand Down
3 changes: 2 additions & 1 deletion bin/node/cli/tests/inspect_works.rs
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ pub mod common;
async fn inspect_works() {
let base_path = tempdir().expect("could not create a temp dir");

common::run_node_for_a_while(base_path.path(), &["--dev"]).await;
common::run_node_for_a_while(base_path.path(), &["--dev", "--disable-hardware-benchmarks"])
.await;

let status = Command::new(cargo_bin("substrate"))
.args(&["inspect", "--dev", "--pruning", "archive", "-d"])
Expand Down
3 changes: 2 additions & 1 deletion bin/node/cli/tests/purge_chain_works.rs
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ pub mod common;
async fn purge_chain_works() {
let base_path = tempdir().expect("could not create a temp dir");

common::run_node_for_a_while(base_path.path(), &["--dev"]).await;
common::run_node_for_a_while(base_path.path(), &["--dev", "--disable-hardware-benchmarks"])
.await;

let status = Command::new(cargo_bin("substrate"))
.args(&["purge-chain", "--dev", "-d"])
Expand Down
3 changes: 2 additions & 1 deletion bin/node/cli/tests/running_the_node_and_interrupt.rs
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ async fn running_the_node_works_and_can_be_interrupted() {
Command::new(cargo_bin("substrate"))
.args(&["--dev", "-d"])
.arg(base_path.path())
.arg("--disable-hardware-benchmarks")
.spawn()
.unwrap(),
);
Expand All @@ -64,7 +65,7 @@ async fn running_the_node_works_and_can_be_interrupted() {
async fn running_two_nodes_with_the_same_ws_port_should_work() {
fn start_node() -> Child {
Command::new(cargo_bin("substrate"))
.args(&["--dev", "--tmp", "--ws-port=45789"])
.args(&["--dev", "--tmp", "--ws-port=45789", "--disable-hardware-benchmarks"])
.spawn()
.unwrap()
}
Expand Down
1 change: 1 addition & 0 deletions bin/node/cli/tests/telemetry.rs
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ async fn telemetry_works() {
let mut substrate = substrate
.args(&["--dev", "--tmp", "--telemetry-url"])
.arg(format!("ws://{} 10", addr))
.arg("--disable-hardware-benchmarks")
.stdout(process::Stdio::piped())
.stderr(process::Stdio::piped())
.stdin(process::Stdio::null())
Expand Down
2 changes: 1 addition & 1 deletion bin/node/cli/tests/temp_base_path_works.rs
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ pub mod common;
async fn temp_base_path_works() {
let mut cmd = Command::new(cargo_bin("substrate"));
let mut child = common::KillChildOnDrop(
cmd.args(&["--dev", "--tmp"])
cmd.args(&["--dev", "--tmp", "--disable-hardware-benchmarks"])
.stdout(Stdio::piped())
.stderr(Stdio::piped())
.spawn()
Expand Down