Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
4c5f9fe
`ecdsa::Public::to_eth_address` + test, beefy-mmr `convert()` to use …
agryaznov Mar 17, 2022
414c40e
`seal_ecdsa_to_eth_address` all but benchmark done
agryaznov Mar 21, 2022
a7453f4
`seal_ecdsa_to_eth_address` + wasm test
agryaznov Mar 21, 2022
7e040fd
`seal_ecdsa_to_eth_address` + benchmark
agryaznov Mar 21, 2022
f843bc8
Merge branch 'master' into ag-seal-to-eth-addr
agryaznov Mar 22, 2022
d3090c7
fixed dependencies
agryaznov Mar 22, 2022
869cf84
Apply suggestions from code review
agryaznov Mar 22, 2022
c4b6a29
fixes from review #1
agryaznov Mar 22, 2022
3dbda9f
Merge branch 'master' into ag-seal-to-eth-addr
agryaznov Mar 30, 2022
f5feb46
ecdsa::Public(*pk).to_eth_address() moved to frame_support and contra…
agryaznov Mar 30, 2022
b801972
beefy-mmr to use newly added frame_support function for convertion
agryaznov Mar 30, 2022
be3e8a9
a doc fix
agryaznov Mar 30, 2022
4037170
import fix
agryaznov Mar 30, 2022
c8ff0ef
benchmark fix-1 (still fails)
agryaznov Mar 30, 2022
976ed7e
benchmark fixed
agryaznov Mar 31, 2022
a26858b
Merge branch 'master' into ag-seal-to-eth-addr
agryaznov Mar 31, 2022
ec8d860
Apply suggestions from code review
agryaznov Apr 8, 2022
b5be45d
fixes on Alex T feedback
agryaznov Apr 8, 2022
2ff93cb
Merge branch 'master' into ag-seal-to-eth-addr
agryaznov Apr 8, 2022
877b57e
to_eth_address() put into extension trait for sp-core::ecdsa::Public
agryaznov Apr 8, 2022
b1ee31f
Update frame/support/src/crypto/ecdsa.rs
agryaznov Apr 11, 2022
16fde71
Update frame/contracts/src/wasm/mod.rs
agryaznov Apr 11, 2022
cdd6bdb
fixes on issues pointed out in review
agryaznov Apr 11, 2022
b51a7b0
benchmark errors fixed
agryaznov Apr 11, 2022
fb1fcc4
Merge branch 'master' into ag-seal-to-eth-addr
agryaznov Apr 11, 2022
41ba268
fmt fix
agryaznov Apr 11, 2022
34779f8
EcdsaRecoverFailed err docs updated
agryaznov Apr 11, 2022
10af685
Merge branch 'master' into ag-seal-to-eth-addr
agryaznov Apr 12, 2022
7c5fa91
Apply suggestions from code review
agryaznov Apr 14, 2022
ec3a2af
make applied suggestions compile
agryaznov Apr 14, 2022
dffce61
get rid of unwrap() in runtime
agryaznov Apr 14, 2022
55c2d06
Merge branch 'master' into ag-seal-to-eth-addr
agryaznov Apr 14, 2022
2997b7e
Remove expect
bkchr Apr 16, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review
Co-authored-by: Alexander Theißen <[email protected]>
  • Loading branch information
agryaznov and athei authored Apr 8, 2022
commit ec8d860b891be645d68e83714ca849a42a8e357c
2 changes: 1 addition & 1 deletion frame/contracts/src/wasm/runtime.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2059,7 +2059,7 @@ define_env!(Env, <E: Ext>,
},

// Calculates Ethereum address from the ECDSA compressed public key and stores
// it into the supplied buffer
// it into the supplied buffer.
//
// # Parameters
//
Expand Down
5 changes: 3 additions & 2 deletions frame/support/src/crypto/ecdsa.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,9 @@
// See the License for the specific language governing permissions and
// limitations under the License.

//! Simple ECDSA secp256k1 API. This is a reduced version of sp_core::crypto::ecdsa to use in
//! contracts.
//! Simple ECDSA secp256k1 API. This is a reduced version of `sp_core::crypto::ecdsa` for use in
//! cases where the performance penalty of doing in-runtime crypto isn't severe. In case this
//! becomes a performance bottleneck a new host function should be considered.
use sp_core::crypto::{ByteArray, UncheckedFrom};

/// The ECDSA compressed public key.
Expand Down