Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@alvicsam
Copy link
Contributor

@alvicsam alvicsam commented May 2, 2022

Attempt to divide .gitlab-ci.yml into several files.
Part of https://github.com/paritytech/ci_cd/issues/325

@alvicsam alvicsam added A3-in_progress Pull request is in progress. No review needed at this stage. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels May 2, 2022
@alvicsam alvicsam requested a review from a team as a code owner May 2, 2022 13:05
@github-actions github-actions bot added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels May 2, 2022
@alvicsam alvicsam requested a review from TriplEight May 2, 2022 14:42
@alvicsam alvicsam changed the title [DO NOT MERGE] Divide .gitlab-ci.yml to several files [ci] Divide .gitlab-ci.yml to several files May 2, 2022
skip-if-draft:
image: paritytech/tools:latest
<<: *kubernetes-env
extends: .kubernetes-env
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extends: has to be used instead of <<: *anchor-name notation.
Just documenting here.

@alvicsam alvicsam requested a review from TriplEight May 3, 2022 15:52
Copy link
Contributor

@TriplEight TriplEight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's try out how to work with it and then evaluate.
@drahnr @sandreim how do you like it?

@TriplEight TriplEight changed the title [ci] Divide .gitlab-ci.yml to several files [ci] Divide .gitlab-ci.yml into several files May 4, 2022
Copy link
Contributor

@drahnr drahnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@paritytech-ci paritytech-ci requested a review from a team May 10, 2022 09:54
@alvicsam alvicsam force-pushed the as-poc-divide-ci branch from 5e4b73c to 7d8951e Compare May 10, 2022 10:52
@alvicsam
Copy link
Contributor Author

Merge after #11384

@alvicsam alvicsam merged commit 34737a2 into master May 11, 2022
@alvicsam alvicsam deleted the as-poc-divide-ci branch May 11, 2022 09:01
godcodehunter pushed a commit to sensoriumxr/substrate that referenced this pull request Jun 22, 2022
* rebase

* update Cargo.lock

* revert Cargo.lock

* fix Cargo.lock from 11384
DaviRain-Su pushed a commit to octopus-network/substrate that referenced this pull request Aug 23, 2022
* rebase

* update Cargo.lock

* revert Cargo.lock

* fix Cargo.lock from 11384
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
* rebase

* update Cargo.lock

* revert Cargo.lock

* fix Cargo.lock from 11384
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants